Skip to content

Commit 124d486

Browse files
committed
fixup! *: plug in no-op metric implementations for nil fields
1 parent 8fe32d3 commit 124d486

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

drpcconn/conn.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func NewWithOptions(tr drpc.Transport, opts Options) *Conn {
6060
}
6161

6262
if opts.CollectMetrics {
63-
mt := drpcmetrics.NewMeteredTransport(tr, opts.Metrics.BytesSent,
63+
mt := drpcmetrics.ToMeteredTransport(tr, opts.Metrics.BytesSent,
6464
opts.Metrics.BytesRecv)
6565
c.tr = mt
6666
}

drpcmetrics/metrics.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ type meteredTransport struct {
6060
bytesRecv Counter
6161
}
6262

63-
// NewMeteredTransport returns a transport that increments bytesSent and
63+
// ToMeteredTransport returns a transport that increments bytesSent and
6464
// bytesRecv on each Write and Read call respectively. Nil counters are
6565
// replaced with no-op implementations.
66-
func NewMeteredTransport(tr drpc.Transport, bytesSent,
66+
func ToMeteredTransport(tr drpc.Transport, bytesSent,
6767
bytesRecv Counter) drpc.Transport {
6868
if bytesSent == nil {
6969
bytesSent = NoOpCounter{}

0 commit comments

Comments
 (0)