crl-release-25.4: fix goroutine leaks in tests#5876
Merged
annrpom merged 2 commits intocockroachdb:crl-release-25.4from Apr 8, 2026
Merged
crl-release-25.4: fix goroutine leaks in tests#5876annrpom merged 2 commits intocockroachdb:crl-release-25.4from
annrpom merged 2 commits intocockroachdb:crl-release-25.4from
Conversation
Add `defer leaktest.AfterTest()` (using the `add-leaktest.sh` script from crlib).
This commit fixes a number of goroutine leaks in tests. A few are not easy to fix and they are used as a TODO (but note that these ones don't leak databases that can spawn new goroutines that can cause false leaks in unrelated tests).
Member
|
This change is |
Contributor
Author
|
The original goal of this was spurred through some AI (and self) delusion trying to fix #5825; I'll still put this up since this change seems to be beneficial nonetheless |
RaduBerinde
approved these changes
Apr 7, 2026
Contributor
Author
|
TFTR! ('-')7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.