crl-release-26.1: rowblk: fix IsLowerBound to account for synthetic suffix#6084
Merged
RaduBerinde merged 1 commit intoMay 27, 2026
Conversation
`Iter.firstUserKey` has the synthetic prefix prepended but the on-disk suffix is preserved; suffix replacement is only applied per-returned key via `maybeReplaceSuffix`. Comparing `firstUserKey` directly against the probe could return true even though the iterator's actual first key (after synthetic suffix replacement) sorts strictly less than the probe, violating the `blockiter.Data.IsLowerBound` contract. When a synthetic suffix is in effect, only compare the prefix portion of `firstUserKey` and require it to be strictly greater than the probe. The contract permits false negatives, so this conservative comparison is sound and avoids reasoning about the unknown suffix. Adds `TestIsLowerBoundRandomized` which cross-checks `IsLowerBound` against `First()` across random blocks and transform combinations, and documents the transform state of `firstUserKey`.
Member
|
This change is |
sumeerbhola
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iter.firstUserKeyhas the synthetic prefix prepended but the on-disksuffix is preserved; suffix replacement is only applied per-returned key
via
maybeReplaceSuffix. ComparingfirstUserKeydirectly against theprobe could return true even though the iterator's actual first key
(after synthetic suffix replacement) sorts strictly less than the probe,
violating the
blockiter.Data.IsLowerBoundcontract.When a synthetic suffix is in effect, only compare the prefix portion of
firstUserKeyand require it to be strictly greater than the probe. Thecontract permits false negatives, so this conservative comparison is
sound and avoids reasoning about the unknown suffix.
Adds
TestIsLowerBoundRandomizedwhich cross-checksIsLowerBoundagainst
First()across random blocks and transform combinations, anddocuments the transform state of
firstUserKey.