db: derive minimumFormatMajorVersion from contents in Batch.Apply#6088
Merged
Conversation
Previously, Batch.Apply asserted (under invariants) that the source batch's minimumFormatMajorVersion was at least the minimum required by each record kind. Not all batch construction paths populate the field; for example, SetRepr on a batch with a nil db skips refreshMemTableSize and leaves minimumFormatMajorVersion at zero Replace the assertion with a ratchet of the receiver's minimumFormatMajorVersion from the per-kind lookup table. The receiver ends up with the correct floor regardless of how the source batch was constructed.
Member
|
This change is |
RaduBerinde
approved these changes
Jun 1, 2026
RaduBerinde
left a comment
RaduBerinde
left a comment
Member
There was a problem hiding this comment.
@RaduBerinde made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
Contributor
Author
|
TFTR! ('-')7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Batch.Apply asserted (under invariants) that the source batch's minimumFormatMajorVersion was at least the minimum required by each record kind. Not all batch construction paths populate the field; for example, SetRepr on a batch with a nil db skips refreshMemTableSize and leaves minimumFormatMajorVersion at zero
Replace the assertion with a ratchet of the receiver's minimumFormatMajorVersion from the per-kind lookup table. The receiver ends up with the correct floor regardless of how the source batch was constructed.