Skip to content

batch: document FormatMajorVersion responsibility on SetRepr #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annrpom merged 1 commit into from
Jun 1, 2026
+4 −0
Merged

batch: document FormatMajorVersion responsibility on SetRepr #6089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,6 +1323,10 @@ func (b *Batch) Repr() []byte {
//
// SetRepr may return ErrInvalidBatch if the supplied slice fails to decode in
// any way. It will not return an error in any other circumstance.
//
// The caller is responsible for ensuring that the batch is applied to a DB at
// a FormatMajorVersion that supports all of the operation kinds encoded in the
// supplied slice.
func (b *Batch) SetRepr(data []byte) error {
h, ok := batchrepr.ReadHeader(data)
if !ok {
Expand Down
Loading