fix: set git.user even on install only#54
Open
joshua-clayton wants to merge 1 commit into
Open
Conversation
Install-only doesn't run cog.sh, so subsequent cog commands can fail, due to git.user.name and git.user.email not being set. So we move the setting to install.sh. Also make the setting conditional, so that if there is already a valid git user set up, we don't override it.
|
✔️ a29d521 - Conventional commits check succeeded. |
Open
Contributor
Author
|
Other than doing it earlier, there is one other minor change, which I think is an improvement. If the user.name and user.email are already set, it leaves them alone. In a CICD runner, this will only be the case if someone has purposely set that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install-only doesn't run cog.sh, so subsequent cog commands can fail, due to
git.user.name and git.user.email not being set.
So we move the setting to install.sh.
Also make the setting conditional, so that if there is already a valid git user set up, we don't override it.