test(qdrant): add unit tests for target connector helpers#1952
Open
nuthalapativarun wants to merge 1 commit into
Open
test(qdrant): add unit tests for target connector helpers#1952nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi, just checking in on this PR — let me know if you need any changes or have any feedback. Happy to update if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_distance_from_spec,_multivector_comparator, and_vector_params_from_defqdrant-clientis not installed (mirrors the pattern used intest_turbopuffer_target.py)The Qdrant connector was the only vector connector without any test coverage.
Test plan
uv run pytest python/tests/connectors/test_qdrant_target.py -vuv run ruff format --check .uv run ruff check .