feat: add detail view and filtering flags to cocoindex show#1972
Open
AkhiChalasani wants to merge 1 commit into
Open
feat: add detail view and filtering flags to cocoindex show#1972AkhiChalasani wants to merge 1 commit into
cocoindex show#1972AkhiChalasani wants to merge 1 commit into
Conversation
Member
|
thanks a lot @AkhiChalasani , @georgeh0 can help take a look! |
georgeh0
reviewed
May 20, 2026
Comment on lines
+633
to
641
| async def _show_from_app(app: App[Any, Any], tree: bool, detail: bool = False, stable_path: str | None = None, recursive: bool = False, parents: bool = False) -> None: | ||
| try: | ||
| await _show_stable_paths(iter_stable_paths(app), tree) | ||
| finally: | ||
| await _stop_all_environments() | ||
|
|
||
|
|
||
| async def _show_from_database(db_path: str, app_name: str, tree: bool) -> None: | ||
| async def _show_from_database(db_path: str, app_name: str, tree: bool, detail: bool = False, stable_path: str | None = None, recursive: bool = False, parents: bool = False) -> None: | ||
| db_path_obj = pathlib.Path(db_path) |
Member
There was a problem hiding this comment.
These arguments are added, but not really used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1830
Adds:
-l/--detailflag for detailed LMDB info-rrecursive children flag-pparents flagSTABLE_PATHargumentOnly the
showcommand was modified. No other commands affected.