Skip to content

fix bug: AnimationController does not override clips in PoseGraph#19163

Open
jcyuan wants to merge 2 commits into
cocos:v3.8.8from
jcyuan:fix-animation-controller
Open

fix bug: AnimationController does not override clips in PoseGraph#19163
jcyuan wants to merge 2 commits into
cocos:v3.8.8from
jcyuan:fix-animation-controller

Conversation

@jcyuan
Copy link
Copy Markdown
Contributor

@jcyuan jcyuan commented Apr 16, 2026

bug desc: #19162

While fixing this BUG, I initially thought it was simply a missing loop for _proceduralPoseStates in state-machine-eval.ts:

    public overrideClips (context: AnimationGraphBindingContext): void {
        ...............
        const { _proceduralPoseStates: proceduralPoseStates } = this;
        const nProcedural = proceduralPoseStates.length;
        for (let iProcedural = 0; iProcedural < nProcedural; ++iProcedural) {
            proceduralPoseStates[iProcedural].overrideClips(context);
        }
    }

However, during the fix, I discovered that the entire ProceduralPoseState was not designed with an overrideClip mechanism at all. So I'm unclear why the official team did it this way... was this functionality accidentally omitted? Or was it never intended for ProceduralPoseState to have clip override capabilities? If this was intentional, please let me know the reason, as this global replacement is crucial for our current animation feature implementation. Thank you!

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@jcyuan jcyuan changed the title fix bug: https://github.com/cocos/cocos-engine/issues/19162 fix bug: AnimationController does not override clips in PoseGraph Apr 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1009738 bytes 1009738 bytes ✅ 0 bytes
2D All (legacy pipeline) 2675347 bytes 2675347 bytes ✅ 0 bytes
2D All (new pipeline) 2767083 bytes 2767083 bytes ✅ 0 bytes
(2D + 3D) All 10024081 bytes 10024648 bytes ⚠️ +567 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16843143 bytes 16843710 bytes ⚠️ +567 bytes

Interface Check Report

This pull request does not change any public interfaces !

@jcyuan jcyuan force-pushed the fix-animation-controller branch from dd5d72f to 69ae036 Compare April 16, 2026 02:56
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant