fix bug: AnimationController does not override clips in PoseGraph#19163
Open
jcyuan wants to merge 2 commits into
Open
fix bug: AnimationController does not override clips in PoseGraph#19163jcyuan wants to merge 2 commits into
jcyuan wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
dd5d72f to
69ae036
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug desc: #19162
While fixing this BUG, I initially thought it was simply a missing loop for
_proceduralPoseStatesinstate-machine-eval.ts:However, during the fix, I discovered that the entire
ProceduralPoseStatewas not designed with anoverrideClipmechanism at all. So I'm unclear why the official team did it this way... was this functionality accidentally omitted? Or was it never intended forProceduralPoseStateto have clip override capabilities? If this was intentional, please let me know the reason, as this global replacement is crucial for our current animation feature implementation. Thank you!