FIX: changed CCTableView's dataSource property from 'strong' to 'weak'#1251
Open
zbarryte wants to merge 1 commit intococos2d:v3.4from
Open
FIX: changed CCTableView's dataSource property from 'strong' to 'weak'#1251zbarryte wants to merge 1 commit intococos2d:v3.4from
zbarryte wants to merge 1 commit intococos2d:v3.4from
Conversation
…' to prevent retain-cycle when using a SpriteBuilder Scene (CCNode that's 0th child of CCScene generated via loading from CCBReader) as the dataSource of a CCTableView
Contributor
|
Hmm. Interesting comparison. UITableView's data source property is weak also. I worry a little bit that since this changes the behavior of the property it will cause compatibility problems for some people. I'll consider merging it into the v4 branch though. Let me get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents retain-cycle that normally occurs when using a SpriteBuilder Scene (CCNode that's 0th child of CCScene generated via loading from CCBReader) as the dataSource of a CCTableView