Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions helloserver/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,11 @@ var users = map[string]string{

func userInfo(w http.ResponseWriter, r *http.Request) {
username := r.URL.Query().Get("name")
displayName := users[username]
displayName, ok := users[username]
if !ok {
http.Error(w, "User not found", http.StatusNotFound)
return
}

// Bug: displayName is "" for unknown users, but we dereference
// a nil *http.Request later by shadowing r.
var detail *http.Request
fmt.Fprintf(w, "User: %s, Host: %s\n", displayName, detail.Host)
fmt.Fprintf(w, "User: %s, Host: %s\n", displayName, r.Host)
}