Skip to content

Commit 01d7bbe

Browse files
committed
fix: Remove root directory from artifact location CY-4520
1 parent 7966f09 commit 01d7bbe

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

cli/src/main/scala/com/codacy/analysis/cli/formatter/Sarif.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,7 @@ private[formatter] class Sarif(val stream: PrintStream, val executionDirectory:
135135

136136
private def createArtifacts(issues: Seq[Issue]): List[SarifReport.Artifact] = {
137137
val filenames: Set[String] = issues.map(_.filename.toString)(collection.breakOut)
138-
filenames.map(filename => SarifReport.Artifact(SarifReport.ArtifactLocation(s"$rootDirectory/$filename")))(
139-
collection.breakOut)
138+
filenames.map(filename => SarifReport.Artifact(SarifReport.ArtifactLocation(s"$filename")))(collection.breakOut)
140139
}
141140

142141
private def createResults(
@@ -151,7 +150,7 @@ private[formatter] class Sarif(val stream: PrintStream, val executionDirectory:
151150
issue <- issues
152151
} yield {
153152
val message = SarifReport.Message(issue.message.text)
154-
val filePath = s"$rootDirectory/${issue.filename.toString}"
153+
val filePath = s"${issue.filename.toString}"
155154
// Some tools return 0 as line number, which doesn't comply with SARIF json schema
156155
val line = if (issue.location.line >= 1) issue.location.line else 1
157156
val locations = List(

cli/src/test/scala/com/codacy/analysis/cli/formatter/SarifSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class SarifSpec extends Specification with NoLanguageFeatures {
6363
Pattern.Specification(securityPatternId, securityPatternLevel, securityPatternCategory, None),
6464
Pattern.Specification(duplicationPatternId, duplicationPatternLevel, duplicationPatternCategory, None)))
6565

66-
val expectedArtifactLocation = s"file:///codacy/${securityIssue.filename.toString}"
66+
val expectedArtifactLocation = s"${securityIssue.filename.toString}"
6767
val expectedReport = SarifReport(
6868
"https://docs.oasis-open.org/sarif/sarif/v2.1.0/cos02/schemas/sarif-schema-2.1.0.json",
6969
"2.1.0",

0 commit comments

Comments
 (0)