Merge pull request #467 from codacy/revert-adding-new-flag

Revert changes TS-180

Author: stefanvacareanu7

README.md

@@ -206,7 +206,6 @@ Found [Clone] 7 duplicated lines with 10 tokens:
     * `--skip-uncommitted-files-check` [default: false] - Skip check for uncommitted files in the analysis directory
     * `--upload` [default: false] - Request to push results to Codacy
     * `--upload-batch-size` [default: 50000] - Maximum number of results in each batch to upload to Codacy
-    * `--skip-docker-test` [default: false] - Skip testing if the default Unix socket for the Docker daemon exists
     * `--skip-ssl-verification` [default: false] - Skip the SSL certificate verification when communicating with the Codacy API
     * `--parallel` [default: 2] - Number of tools to run in parallel
     * `--max-allowed-issues` [default: 0] - Maximum number of issues allowed for the analysis to succeed

bin/codacy-analysis-cli.sh

@@ -18,12 +18,10 @@ log_error() {
 }
 
 test_docker_socket() {
-  if [ "${SKIP_DOCKER_TEST}" == false ]; then
-    if [ ! -S /var/run/docker.sock ]; then
-      log_error "/var/run/docker.sock must exist as a Unix domain socket"
-    elif [ -n "${DOCKER_HOST}" ] && [ "${DOCKER_HOST}" != "unix:///var/run/docker.sock" ]; then
-      log_error "invalid DOCKER_HOST=${DOCKER_HOST}, must be unset or unix:///var/run/docker.sock"
-    fi
+  if [ ! -S /var/run/docker.sock ]; then
+    log_error "/var/run/docker.sock must exist as a Unix domain socket"
+  elif [ -n "${DOCKER_HOST}" ] && [ "${DOCKER_HOST}" != "unix:///var/run/docker.sock" ]; then
+    log_error "invalid DOCKER_HOST=${DOCKER_HOST}, must be unset or unix:///var/run/docker.sock"
   fi
 }
 
@@ -119,13 +117,6 @@ prep_args_with_output_absolute_path() {
   ARGUMENTS_WITH_ABSOLUTE_PATH_OUTPUT="$new_args"
 }
 
-SKIP_DOCKER_TEST=false
-while [[ "$#" -gt 0 ]]; do
-    case $1 in
-        --skip-docker-test) SKIP_DOCKER_TEST=true ;;
-    esac
-    shift
-done
 
 test_docker_socket