Skip to content

Commit 5544b01

Browse files
author
Francisco
committed
fix: Fix severity level in Sarif CY-3724
Sarif downgrades severity level for non-security issues. But the CLI was not detecting security patternts the correct way. This commit should fix that
1 parent 898409c commit 5544b01

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

  • cli/src/main/scala/com/codacy/analysis/cli/formatter

cli/src/main/scala/com/codacy/analysis/cli/formatter/Sarif.scala

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,15 @@ private[formatter] class Sarif(val stream: PrintStream, val executionDirectory:
123123
(for {
124124
issue <- issues.groupBy(_.patternId.value).collect { case (_, issue :: _) => issue }
125125
modelPattern <- patternsMap.get(issue.patternId.value)
126-
} yield SarifReport.Rule(
127-
id = issue.patternId.value,
128-
name = modelPattern.title,
129-
shortDescription = SarifReport.Message(modelPattern.description.getOrElse(modelPattern.title)),
130-
help = SarifReport
131-
.Message(text = modelPattern.description.getOrElse(modelPattern.title), markdown = modelPattern.explanation),
132-
properties =
133-
SarifReport.RuleProperties(category = issue.category.getOrElse(Pattern.Category.CodeStyle).toString))).toList
126+
} yield
127+
SarifReport.Rule(
128+
id = issue.patternId.value,
129+
name = modelPattern.title,
130+
shortDescription = SarifReport.Message(modelPattern.description.getOrElse(modelPattern.title)),
131+
help = SarifReport
132+
.Message(text = modelPattern.description.getOrElse(modelPattern.title), markdown = modelPattern.explanation),
133+
properties =
134+
SarifReport.RuleProperties(category = issue.category.getOrElse(Pattern.Category.CodeStyle).toString))).toList
134135
}
135136

136137
private def createArtifacts(issues: Seq[Issue]): List[SarifReport.Artifact] = {

0 commit comments

Comments
 (0)