refactor: streamline installation feedback and enhance tool path resolution - Simplify installation status reporting for runtimes and tools by removing redundant checks - Improve handling of relative binary paths in tool installation checks

Author: andrzej-janczak

cmd/install.go

@@ -217,22 +217,18 @@ var installCmd = &cobra.Command{
 		var hasFailures bool
 		for name, runtime := range cfg.Config.Runtimes() {
 			if !cfg.Config.IsRuntimeInstalled(name, runtime) {
-				if cfg.Config.IsRuntimeInstalled(name, runtime) {
-					green.Printf("  ✓ Runtime: %s v%s\n", name, runtime.Version)
-				} else {
-					color.Yellow("  ⚠️  Runtime: %s v%s (installation failed)", name, runtime.Version)
-					hasFailures = true
-				}
+				color.Yellow("  ⚠️  Runtime: %s v%s (installation failed)", name, runtime.Version)
+				hasFailures = true
+			} else {
+				green.Printf("  ✓ Runtime: %s v%s\n", name, runtime.Version)
 			}
 		}
 		for name, tool := range cfg.Config.Tools() {
 			if !cfg.Config.IsToolInstalled(name, tool) {
-				if cfg.Config.IsToolInstalled(name, tool) {
-					green.Printf("  ✓ Tool: %s v%s\n", name, tool.Version)
-				} else {
-					color.Yellow("  ⚠️  Tool: %s v%s (installation failed)", name, tool.Version)
-					hasFailures = true
-				}
+				color.Yellow("  ⚠️  Tool: %s v%s (installation failed)", name, tool.Version)
+				hasFailures = true
+			} else {
+				green.Printf("  ✓ Tool: %s v%s\n", name, tool.Version)
 			}
 		}
 		fmt.Println()
@@ -247,24 +243,3 @@ var installCmd = &cobra.Command{
 		}
 	},
 }
-
-func installRuntimes(config *cfg.ConfigType) {
-	err := cfg.InstallRuntimes(config)
-	if err != nil {
-		logger.Error("Failed to install runtimes", logrus.Fields{
-			"error": err.Error(),
-		})
-		log.Fatal(err)
-	}
-}
-
-func installTools(config *cfg.ConfigType, registry string) {
-	// Use the new tools-installer instead of manual installation
-	err := cfg.InstallTools(config, registry)
-	if err != nil {
-		logger.Error("Failed to install tools", logrus.Fields{
-			"error": err.Error(),
-		})
-		log.Fatal(err)
-	}
-}

config/config.go

@@ -209,10 +209,21 @@ func (c *ConfigType) IsToolInstalled(name string, tool *plugins.ToolInfo) bool {
 
 	// Check if at least one binary exists
 	for _, binaryPath := range tool.Binaries {
+		// If the path is relative, join it with the installation directory
+		if !filepath.IsAbs(binaryPath) {
+			binaryPath = filepath.Join(tool.InstallDir, binaryPath)
+		}
+
+		// Try both with and without .exe
 		_, err := os.Stat(binaryPath)
 		if err == nil {
 			return true
 		}
+
+		_, err = os.Stat(binaryPath + ".exe")
+		if err == nil {
+			return true
+		}
 	}
 
 	return false