refactor: route codacy-client, tools, download through httpclient (OD-30)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: andrzej-janczak

codacy-client/client.go

@@ -2,6 +2,7 @@ package codacyclient
 
 import (
 	"codacy/cli-v2/domain"
+	"codacy/cli-v2/utils/httpclient"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -16,8 +17,9 @@ const timeout = 10 * time.Second
 var CodacyApiBase = "https://app.codacy.com"
 
 func getRequest(url string, apiToken string) ([]byte, error) {
-	client := &http.Client{
-		Timeout: timeout,
+	client, err := httpclient.New(httpclient.WithTimeout(timeout))
+	if err != nil {
+		return nil, fmt.Errorf("failed to create http client: %w", err)
 	}
 
 	req, err := http.NewRequest("GET", url, nil)

tools/patterns.go

@@ -2,6 +2,7 @@ package tools
 
 import (
 	"codacy/cli-v2/domain"
+	"codacy/cli-v2/utils/httpclient"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -11,8 +12,9 @@ import (
 
 // FetchDefaultEnabledPatterns fetches default patterns from Codacy API for a given tool UUID
 func FetchDefaultEnabledPatterns(toolUUID string) ([]domain.PatternDefinition, error) {
-	client := &http.Client{
-		Timeout: 10 * time.Second,
+	client, err := httpclient.New(httpclient.WithTimeout(10 * time.Second))
+	if err != nil {
+		return nil, fmt.Errorf("failed to create http client: %w", err)
 	}
 
 	// Fetch default patterns from Codacy API

utils/download.go

@@ -1,6 +1,7 @@
 package utils
 
 import (
+	"codacy/cli-v2/utils/httpclient"
 	"codacy/cli-v2/utils/logger"
 	"fmt"
 	"io"
@@ -47,7 +48,10 @@ func DownloadFile(url string, destDir string) (string, error) {
 	logger.Debug("Making HTTP GET request", logrus.Fields{
 		"url": url,
 	})
-	client := &http.Client{}
+	client, err := httpclient.New(httpclient.WithTimeout(0)) // no timeout: large binaries
+	if err != nil {
+		return "", fmt.Errorf("failed to create http client: %w", err)
+	}
 	req, err := http.NewRequest("GET", url, nil)
 	if err != nil {
 		return "", fmt.Errorf("failed to create request: %w", err)