refactor: streamline runtime installation checks and update test cases

- Replace direct calls to isRuntimeInstalled with Config.IsRuntimeInstalled for consistency in runtime checks
- Remove the isRuntimeInstalled function to simplify the codebase
- Update test cases to reflect changes in runtime installation checks

Author: andrzej-janczak

cmd/init.go

@@ -279,27 +279,6 @@ func configFileTemplate(tools []tools.Tool) string {
 	return sb.String()
 }
 
-func processRuntime(name, version string) (*plugins.RuntimeInfo, error) {
-	configs := []plugins.RuntimeConfig{
-		{
-			Name:    name,
-			Version: version,
-		},
-	}
-
-	runtimeInfos, err := plugins.ProcessRuntimes(configs, os.TempDir())
-	if err != nil {
-		return nil, err
-	}
-
-	info, ok := runtimeInfos[name]
-	if !ok {
-		return nil, fmt.Errorf("runtime %s not found in processed runtimes", name)
-	}
-
-	return info, nil
-}
-
 func cliConfigFileTemplate(cliLocalMode bool) string {
 	var cliModeString string
 

config/runtimes-installer.go

@@ -47,9 +47,8 @@ func InstallRuntimes(config *ConfigType) error {
 
 // InstallRuntime installs a specific runtime
 func InstallRuntime(name string, runtimeInfo *plugins.RuntimeInfo) error {
-
-	// Check if the runtime is already installed
-	if isRuntimeInstalled(runtimeInfo) {
+	// Skip if already installed
+	if Config.IsRuntimeInstalled(name, runtimeInfo) {
 		logger.Info("Runtime already installed", logrus.Fields{
 			"runtime": name,
 			"version": runtimeInfo.Version,
@@ -65,7 +64,7 @@ func InstallRuntime(name string, runtimeInfo *plugins.RuntimeInfo) error {
 	}
 
 	// Verify that the runtime binaries are available
-	if !isRuntimeInstalled(runtimeInfo) {
+	if !Config.IsRuntimeInstalled(name, runtimeInfo) {
 		logger.Error("Runtime binaries not found after extraction", logrus.Fields{
 			"runtime": name,
 			"version": runtimeInfo.Version,
@@ -76,37 +75,6 @@ func InstallRuntime(name string, runtimeInfo *plugins.RuntimeInfo) error {
 	return nil
 }
 
-// isRuntimeInstalled checks if a runtime is already installed by checking for the binary
-func isRuntimeInstalled(runtimeInfo *plugins.RuntimeInfo) bool {
-	// If there are no binaries, check the install directory
-	if len(runtimeInfo.Binaries) == 0 {
-		_, err := os.Stat(runtimeInfo.InstallDir)
-		if err != nil {
-			logger.Debug("Runtime install directory not found", logrus.Fields{
-				"directory": runtimeInfo.InstallDir,
-				"error":     err,
-			})
-			return false
-		}
-		return true
-	}
-
-	// Check if at least one binary exists
-	for binaryName, binaryPath := range runtimeInfo.Binaries {
-		_, err := os.Stat(binaryPath)
-		if err != nil {
-			logger.Debug("Runtime binary not found", logrus.Fields{
-				"binary": binaryName,
-				"path":   binaryPath,
-				"error":  err,
-			})
-			return false
-		}
-	}
-
-	return true
-}
-
 // downloadAndExtractRuntime downloads and extracts a runtime
 func downloadAndExtractRuntime(runtimeInfo *plugins.RuntimeInfo) error {
 	// Create a file name for the downloaded archive

config/runtimes-installer_test.go

@@ -24,14 +24,14 @@ func TestIsRuntimeInstalled(t *testing.T) {
 	}
 
 	// Test when the install directory doesn't exist
-	assert.False(t, isRuntimeInstalled(runtimeInfoNoBinaries))
+	assert.False(t, Config.IsRuntimeInstalled("test-runtime", runtimeInfoNoBinaries))
 
 	// Create the install directory
 	err = os.MkdirAll(runtimeInfoNoBinaries.InstallDir, utils.DefaultDirPerms)
 	assert.NoError(t, err)
 
 	// Test when the install directory exists
-	assert.True(t, isRuntimeInstalled(runtimeInfoNoBinaries))
+	assert.True(t, Config.IsRuntimeInstalled("test-runtime", runtimeInfoNoBinaries))
 
 	// Create a mock RuntimeInfo with binaries
 	binPath := filepath.Join(tempDir, "test-runtime-bin")
@@ -45,12 +45,12 @@ func TestIsRuntimeInstalled(t *testing.T) {
 	}
 
 	// Test when the binary doesn't exist
-	assert.False(t, isRuntimeInstalled(runtimeInfoWithBinaries))
+	assert.False(t, Config.IsRuntimeInstalled("test-runtime", runtimeInfoWithBinaries))
 
 	// Create a mock binary file
 	_, err = os.Create(binPath)
 	assert.NoError(t, err)
 
 	// Test when the binary exists
-	assert.True(t, isRuntimeInstalled(runtimeInfoWithBinaries))
+	assert.True(t, Config.IsRuntimeInstalled("test-runtime", runtimeInfoWithBinaries))
 }

config/tools-installer.go

@@ -58,7 +58,7 @@ func InstallTools(config *ConfigType, registry string) error {
 // InstallTool installs a specific tool
 func InstallTool(name string, toolInfo *plugins.ToolInfo, registry string) error {
 	// Check if the tool is already installed
-	if isToolInstalled(toolInfo) {
+	if Config.IsToolInstalled(name, toolInfo) {
 		logger.Info("Tool already installed", logrus.Fields{
 			"tool":    name,
 			"version": toolInfo.Version,