feature: Continue installation when some tools fails to install [PLUTO-1417]#106
Merged
Merged
Conversation
…gs - Replace fatal errors with warnings for failed installations of runtimes and tools - Update installation completion message to reflect any failures - Add guideline to remove dead unused code
…lution - Simplify installation status reporting for runtimes and tools by removing redundant checks - Improve handling of relative binary paths in tool installation checks
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
machadoit
reviewed
May 8, 2025
| var failedTools []string | ||
|
|
||
| for name, toolInfo := range config.Tools() { | ||
| logger.Info("Starting tool installation", map[string]interface{}{ |
Contributor
There was a problem hiding this comment.
Why these ones use a map instead of the logrus?
Contributor
Author
There was a problem hiding this comment.
thanks, changed
andrzej-janczak
changed the title
machadoit
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue installation process when tools fail to install PLUTO-1417
Description
This PR improves the CLI's resilience by continuing the installation process even when individual tools or runtimes fail to install. Previously, any installation failure would stop the entire process. Now users get a complete picture of what succeeded and what failed.
Key Changes
Modified installation process to continue even when tools/runtimes fail
Added clear visual indicators for installation status:
Improved final installation summary showing both successes and failures
Fixed tool detection issues:
Bring back windows IT test