Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
zhamborova
force-pushed
the
fix_java
branch
2 times, most recently
from
043b365 to
bb33d65
Compare
| // This should be called separately after MergeSarifOutputs if rule filtering is required | ||
| func FilterRulesFromSarif(sarifData []byte) ([]byte, error) { | ||
| // Use a map to preserve all fields during unmarshaling | ||
| var report map[string]interface{} |
There was a problem hiding this comment.
I think it was ok work on the parsed (structure) version var report SarifReport
There was a problem hiding this comment.
these change are due to previously disappeared fields in serifs
There was a problem hiding this comment.
what I mean is that this version, it has this longer implementation, but doing exactly same thing
So I think we can just get back to old impl of this and it should be fine right ? 🤔
There was a problem hiding this comment.
I reverted to your versions, but there are now missing fields in the actual sarif that we used have, especially visible in eslint failure 🤔
zhamborova
changed the title
This reverts commit 99059bd.
3 participants
This pull request includes several changes across multiple areas, focusing on improving workflows, enhancing SARIF output processing, updating runtime and tool configurations, and refining integration test scripts. Below is a summary of the most important changes, grouped by theme:
Workflow Improvements
yqon Windows in.github/workflows/it-test.ymland added a newidfor theRun init tests on Windowsstep. This simplifies the workflow and ensures better test identification.Check test resultsstep to always run and added detailed checks for test outcomes on both Windows and Unix, improving error detection and reporting.SARIF Output Enhancements
analyzeCmdincmd/analyze.goto filter rules from merged SARIF outputs before writing to a file or printing, ensuring cleaner and more relevant output.eslint,lizard,pmd,semgrep, etc.) to replace detailed rule definitions withrules: null, simplifying the SARIF structure. [1] [2] [3] [4] [5] [6]Runtime and Tool Configuration Updates
java@17.0.10to the list of runtimes inintegration-tests/init-with-token/expected/codacy.yamlandintegration-tests/init-without-token/expected/codacy.yaml, reflecting updated runtime support. [1] [2]Integration Test Refinements
Normalize-Configfunction inintegration-tests/run.ps1to preserve YAML structure and sort within sections, improving test output consistency.Compare-Filesfunction inintegration-tests/run.ps1to provide more detailed diff output when files do not match, aiding debugging. [1] [2]Cleanup of Legacy Configurations
integration-tests/init-with-token/expected/.codacy/codacy.yaml, ensuring alignment with current standards.These changes collectively enhance the maintainability, accuracy, and robustness of the workflows, SARIF processing, and integration tests.