fix eslint config creation and using default 8.57.0 instead 9.3.0 (when init without token)#125
Merged
franciscoovazevedo merged 2 commits intomainfrom May 20, 2025
Merged
Conversation
…3.0 (when init without token)
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ESLint configuration generation by ensuring proper handling of ESLint rule parameters and updating the default ESLint version to 8.57.0.
- Fixed the format of ESLint rule definitions (using consistent array notation) and improved default parameter handling.
- Updated integration tests, CLI command templates, and documentation to reflect the new default ESLint version.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/eslintConfigCreator_test.go | Added tests for default and unnamed parameter handling |
| tools/eslintConfigCreator.go | Updated parameter processing logic and ensured proper JSON formatting |
| integration-tests/init-without-token/expected/codacy.yaml | Updated default ESLint version |
| cmd/root.go | Updated default ESLint version in CLI usage examples |
| cmd/init_test.go | Updated integration test expectation for default ESLint version |
| cmd/init.go | Changed default ESLint version to 8.57.0 |
| README.md | Updated documentation to reflect the new default ESLint version |
zhamborova
reviewed
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ESLint configuration generation
Changes
ESLint Configuration Generation
["error", ...]instead of mixing formatsBenefits