refactor: Uniform init defaults - PLUTO-1426

[franciscoovazevedo]

No description provided.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.79%	✅ 54.81%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (c7a56ea)	4585	1411	30.77%
Head commit (bab1ed5)	4531 (-54)	1430 (+19)	31.56% (+0.79%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#127)	104	57	54.81%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[Copilot]

Pull Request Overview

This PR refactors the configuration file creation logic for several tools to uniformly use provided defaults and simplify file writing. Key changes include updating the function signatures for ESLint and Lizard configuration creation to write files directly, adding helper functions for parameter handling, and streamlining config file creation in the init command.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
tools/lizard/lizardConfigCreator.go	Updates CreateLizardConfig to accept a toolsConfigDir and write the config directly.
tools/eslintConfigCreator_test.go	Revises tests to use temporary directories and read back the generated ESLint config.
tools/eslintConfigCreator.go	Refactors ESLint config creation to use a new helper (removePlugins) and write file using a common helper.
cmd/init.go	Adjusts calls to config creation functions for ESLint and Lizard to accommodate their new signatures.

Comments suppressed due to low confidence (2)

tools/eslintConfigCreator.go:115

• The new removePlugins function now skips any rule that contains an underscore based solely on its plugin check, whereas the previous implementation checked for plugin rules using '/'. Please ensure this change in behavior is intended and covers all required cases.

rule, skipRule := removePlugins(rule)

cmd/init.go:418

• The removal of the branch that retrieves default Lizard configuration when patternConfiguration is empty may lead to an empty configuration file. Confirm that this change is intended under the new uniform default behavior.

patterns := make([]domain.PatternDefinition, len(patternConfiguration))

[zhamborova]

lgtm

[zhamborova]

suggestion: we could also refactor this function: we could abstract the error handling and logging, wdyt?

[franciscoovazevedo]

we can and should, but I think we should do it for all tools and not just eslint, in the same PR