Skip to content

Refactor configuration management functions to be more generic and re…#149

Merged
franciscoovazevedo merged 1 commit intopluto-1422from
1422-refactor
Jun 11, 2025
Merged

Refactor configuration management functions to be more generic and re…#149
franciscoovazevedo merged 1 commit intopluto-1422from
1422-refactor

Conversation

@andrzej-janczak
Copy link
Copy Markdown
Contributor

…duce code duplication. Updated runtime and tool handling functions to use a unified entry list update method. Improved addToCodacyYaml function for better maintainability.

…duce code duplication. Updated runtime and tool handling functions to use a unified entry list update method. Improved addToCodacyYaml function for better maintainability.
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.15% 75.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c80dceb) 5438 1433 26.35%
Head commit (14d51e9) 5419 (-19) 1420 (-13) 26.20% (-0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#149) 20 15 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@franciscoovazevedo franciscoovazevedo merged commit edd7158 into pluto-1422 Jun 11, 2025
10 checks passed
@franciscoovazevedo franciscoovazevedo deleted the 1422-refactor branch June 11, 2025 13:20
franciscoovazevedo added a commit that referenced this pull request Jun 12, 2025
…UTO-1422 (#145)

* not fail when analysing tool/runtime that is not installed

* added tests and fixed bug with runtime installation

* refactoring runTools to be more generic

* lizard refactor to have logic of running in runner

* refactor upload to use codacyclient, use domain types and run lizard like other tools

* removed extra prints on downloading runtimes

* fixed small issues

* add default_version to enigma and validate tool name to be sure we are not trying to install typo tool

* reverted default_version from enigma plugin and code review changes

* Refactor configuration management functions to be more generic and reduce code duplication. Updated runtime and tool handling functions to use a unified entry list update method. Improved addToCodacyYaml function for better maintainability. (#149)

---------

Co-authored-by: Andrzej Janczak <122018786+andrzej-janczak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants