Skip to content

fix: no longer downloads node binary if it is already present #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machadoit merged 1 commit into from
Mar 27, 2025
Merged

fix: no longer downloads node binary if it is already present #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions config/node-utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"log"
"os"
"path"
"path/filepath"
"runtime"
)

Expand Down Expand Up @@ -60,23 +61,30 @@ func getNodeDownloadURL(nodeRuntime *Runtime) string {
func InstallNode(r *Runtime) error {
// TODO should delete downloaded archive
// TODO check for deflated archive
log.Println("Fetching node...")
downloadNodeURL := getNodeDownloadURL(r)
nodeTar, err := utils.DownloadFile(downloadNodeURL, Config.RuntimesDirectory())
if err != nil {
return err
}

// deflate node archive
t, err := os.Open(nodeTar)
fileName := filepath.Base(downloadNodeURL)
t, err := os.Open(filepath.Join(Config.RuntimesDirectory(), fileName))
defer t.Close()
if err != nil {
return err
log.Println("Node is not present, fetching node...")
nodeTar, err := utils.DownloadFile(downloadNodeURL, Config.RuntimesDirectory())
if err != nil {
return err
}
t, err = os.Open(nodeTar)
defer t.Close()
if err != nil {
return err
}
} else {
fmt.Println("Node is already present...")
}
fmt.Println("Extracting node...")
// deflate node archive

err = utils.ExtractTarGz(t, Config.RuntimesDirectory())
if err != nil {
return err
}

return nil
}