Skip to content

fix: sarif output#161

Closed
andrzej-janczak wants to merge 1 commit intomainfrom
fix/pmd7
Closed

fix: sarif output#161
andrzej-janczak wants to merge 1 commit intomainfrom
fix/pmd7

Conversation

@andrzej-janczak
Copy link
Copy Markdown
Contributor

@andrzej-janczak andrzej-janczak commented Jul 4, 2025

@andrzej-janczak andrzej-janczak deleted the fix/pmd7 branch July 4, 2025 13:54
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6c9c7f2) 5621 1069 19.02%
Head commit (2e7a3f3) 5614 (-7) 1069 (+0) 19.04% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#161) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Comment thread example_1.ts
});

http.createServer((req, res) => {
const parsedUrl = url.parse(req.url || '', true);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Prefer using nullish coalescing operator (??) instead of a logical or (||), as it is a safer operator.

Suggested change
const parsedUrl = url.parse(req.url || '', true);
const parsedUrl = url.parse(req.url ?? '', true);

Comment thread example_1.ts
if (err) throw err;

// 3. Exposição de dados sensíveis - FIXED: Filter sensitive fields
const safeResult = result.map((user: any) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Unexpected any. Specify a different type.

Suggested change
const safeResult = result.map((user: any) => {
const safeResult = result.map((user: unknown) => {

Comment thread example_1.ts

// 3. Exposição de dados sensíveis - FIXED: Filter sensitive fields
const safeResult = result.map((user: any) => {
const { password, ...safeUser } = user;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: 'password' is assigned a value but never used.

Suggested change
const { password, ...safeUser } = user;
const { ...safeUser } = user;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant