Skip to content

fix: listing tools and patterns should allow disabled ones too#170

Merged
heliocodacy merged 2 commits intomainfrom
list-tools-should-allow-disabled-too
Aug 7, 2025
Merged

fix: listing tools and patterns should allow disabled ones too#170
heliocodacy merged 2 commits intomainfrom
list-tools-should-allow-disabled-too

Conversation

@heliocodacy
Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Aug 7, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -0.50%) 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (73051d7) 5665 1095 19.33%
Head commit (2876f7b) 5667 (+2) 1095 (+0) 19.32% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#170) 11 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@machadoit
Copy link
Copy Markdown
Contributor

What are we trying to fix behavior wise?

@heliocodacy
Copy link
Copy Markdown
Contributor Author

What are we trying to fix behavior wise?

When a tool is using a configuration file and a user tries to upload a sarif file, if the pattern is disabled by default, it doesn't map the issues for that pattern.

@machadoit
Copy link
Copy Markdown
Contributor

What are we trying to fix behavior wise?

When a tool is using a configuration file and a user tries to upload a sarif file, if the pattern is disabled by default, it doesn't map the issues for that pattern.

I see... makes sense then! Seems some tests are failing, not sure if something you can also add anything to test that case to avoid regression?

@heliocodacy heliocodacy force-pushed the list-tools-should-allow-disabled-too branch 2 times, most recently from b88faea to 9b5be9e Compare August 7, 2025 09:48
@heliocodacy heliocodacy force-pushed the list-tools-should-allow-disabled-too branch from 9b5be9e to 2876f7b Compare August 7, 2025 09:51
@heliocodacy heliocodacy enabled auto-merge (squash) August 7, 2025 09:57
@heliocodacy heliocodacy merged commit 945dc88 into main Aug 7, 2025
8 of 9 checks passed
@heliocodacy heliocodacy deleted the list-tools-should-allow-disabled-too branch August 7, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants