Skip to content

Replace Printf on analyse with log.info #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heliocodacy merged 4 commits into from
Nov 25, 2025
Merged

Replace Printf on analyse with log.info #183

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b64f2e6
"Replace Printf on analyse with log.info"
heliocodacy Nov 25, 2025
797f5f8
Fix string format
heliocodacy Nov 25, 2025
b6eba8c
remove fmt.println
heliocodacy Nov 25, 2025
d489b4a
fix trivy test due to db update
heliocodacy Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
if _, err := os.Stat(toolConfigPath); os.IsNotExist(err) {
// Config file does not exist - create it if we have the means to do so
if (!cliLocalMode && initFlags.ApiToken != "") || cliLocalMode {
fmt.Printf("Creating new config file for tool %s\n", toolName)
logger.Info("Creating new config file for tool %s\n", toolName)

Check failure on line 320 in cmd/analyze.go

View workflow job for this annotation

GitHub Actions / build 

cannot use toolName (variable of type string) as logrus.Fields value in argument to logger.Info

Check failure on line 320 in cmd/analyze.go

View workflow job for this annotation

GitHub Actions / test 

cannot use toolName (variable of type string) as logrus.Fields value in argument to logger.Info

Check failure on line 320 in cmd/analyze.go

View workflow job for this annotation

GitHub Actions / build 

cannot use toolName (variable of type string) as logrus.Fields value in argument to logger.Info
Comment thread
heliocodacy marked this conversation as resolved.
Outdated
Copy link
Copy Markdown

@codacy-production codacy-production Bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Using logger.Info("Creating new config file for tool %s\n", toolName) mixes printf-style formatting with structured logging idioms. Confirm that logger.Info supports format strings and that the newline is necessary — prefer structured logging (e.g. logger.Infof(...) if available, or logger.Info("Creating new config file for tool", "tool", toolName)) to avoid ambiguity.

Medium risk | Medium confidence

if err := configsetup.CreateToolConfigurationFile(toolName, initFlags); err != nil {
return fmt.Errorf("failed to create config file for tool %s: %w", toolName, err)
Comment on lines 319 to 321
Copy link
Copy Markdown

@codacy-production codacy-production Bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] You removed the fmt.Printf("Creating new config file for tool %s\n", toolName) line. If the intent is to silence standard output, prefer emitting the same message via the configured logging facility (e.g. logger.Info(...)) so users still get feedback when running with standard verbosity. If silent behavior is desired, add a brief comment explaining why the user-facing notification was removed to avoid regression surprises.

Low risk | Low confidence

Comment thread
heliocodacy marked this conversation as resolved.
}
Expand Down
Loading