address review comments

Author: alerizzo

package.json

@@ -40,7 +40,7 @@
   "author": "Codacy <support@codacy.com> (https://www.codacy.com)",
   "license": "ISC",
   "engines": {
-    "node": ">=18"
+    "node": ">=20"
   },
   "dependencies": {
     "@codacy/tooling": "0.1.0",

src/utils/import-config.test.ts

@@ -103,6 +103,27 @@ describe("readConfigFile", () => {
     expect(() => readConfigFile(tmpPath)).toThrow("missing");
     fs.unlinkSync(tmpPath);
   });
+
+  it("should throw when a tool entry is missing toolId", () => {
+    const tmpPath = "/tmp/test-no-toolid.json";
+    fs.writeFileSync(tmpPath, JSON.stringify({
+      version: 1,
+      tools: [{ patterns: [] }],
+    }));
+    expect(() => readConfigFile(tmpPath)).toThrow("tools[0] is missing a valid 'toolId'");
+    fs.unlinkSync(tmpPath);
+  });
+
+  it("should default patterns to empty array when missing", () => {
+    const tmpPath = "/tmp/test-no-patterns.json";
+    fs.writeFileSync(tmpPath, JSON.stringify({
+      version: 1,
+      tools: [{ toolId: "eslint" }],
+    }));
+    const result = readConfigFile(tmpPath);
+    expect(result.tools[0].patterns).toEqual([]);
+    fs.unlinkSync(tmpPath);
+  });
 });
 
 // ─── resolveToolId ────────────────────────────────────────────────────

src/utils/import-config.ts

@@ -37,6 +37,18 @@ export function readConfigFile(filePath: string): CodacyConfig {
     if (!config.version || !Array.isArray(config.tools)) {
       throw new Error("Invalid configuration file: missing 'version' or 'tools' fields.");
     }
+    for (let i = 0; i < config.tools.length; i++) {
+      const tool = config.tools[i];
+      if (!tool || typeof tool !== "object") {
+        throw new Error(`Invalid configuration file: tools[${i}] must be an object.`);
+      }
+      if (typeof tool.toolId !== "string" || tool.toolId.trim() === "") {
+        throw new Error(`Invalid configuration file: tools[${i}] is missing a valid 'toolId'.`);
+      }
+      if (!Array.isArray(tool.patterns)) {
+        tool.patterns = [];
+      }
+    }
     return config;
   } catch (err) {
     if (err instanceof SyntaxError) {
@@ -110,7 +122,7 @@ export function buildImportPreview(
   );
 
   const totalPatterns = config.tools.reduce(
-    (sum, t) => sum + t.patterns.length,
+    (sum, t) => sum + (Array.isArray(t.patterns) ? t.patterns.length : 0),
     0,
   );