Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: alerizzo

src/commands/login.ts

@@ -76,6 +76,11 @@ Get your token at: https://app.codacy.com/account/access-management
               "Invalid API token. Check that it is correct and not expired.",
             );
           }
+          if (typeof apiErr?.status === "number") {
+            throw new Error(
+              `Codacy API returned an error (status ${apiErr.status}). Please try again or check your permissions.`,
+            );
+          }
           throw new Error(
             "Could not reach the Codacy API. Check your network connection.",
           );

src/utils/credentials.test.ts

@@ -11,19 +11,18 @@ import {
   getCredentialsPath,
 } from "./credentials";
 
+const mockHomeDir = path.join(os.tmpdir(), `.codacy-home-${process.pid}`);
+
 vi.mock("node:os", async () => {
   const actual = await vi.importActual<typeof import("node:os")>("node:os");
   return {
     ...actual,
-    homedir: () => os.tmpdir().replace(/\/$/, "") + "/.codacy-home-" + process.pid,
+    homedir: () => mockHomeDir,
   };
 });
 
 describe("credentials", () => {
-  const credentialsDir = path.join(
-    os.tmpdir().replace(/\/$/, "") + "/.codacy-home-" + process.pid,
-    ".codacy",
-  );
+  const credentialsDir = path.join(mockHomeDir, ".codacy");
   const credentialsFile = path.join(credentialsDir, "credentials");
 
   beforeEach(() => {

src/utils/credentials.ts

@@ -91,26 +91,35 @@ export function saveCredentials(token: string): void {
 }
 
 export function loadCredentials(): string | null {
+  if (!fs.existsSync(CREDENTIALS_FILE)) {
+    return null;
+  }
+
+  const payload = fs.readFileSync(CREDENTIALS_FILE, "utf8");
+
   try {
-    if (!fs.existsSync(CREDENTIALS_FILE)) {
-      return null;
-    }
-    const payload = fs.readFileSync(CREDENTIALS_FILE, "utf8");
     return decryptToken(payload);
   } catch {
+    // Treat invalid/corrupted credentials as "no credentials"
     return null;
   }
 }
 
 export function deleteCredentials(): boolean {
+  if (!fs.existsSync(CREDENTIALS_FILE)) {
+    return false;
+  }
+
   try {
-    if (!fs.existsSync(CREDENTIALS_FILE)) {
-      return false;
-    }
     fs.unlinkSync(CREDENTIALS_FILE);
     return true;
-  } catch {
-    return false;
+  } catch (error) {
+    const err = error as NodeJS.ErrnoException;
+    if (err.code === "ENOENT") {
+      // File was removed between the existence check and unlink
+      return false;
+    }
+    throw error;
   }
 }
 
@@ -129,24 +138,28 @@ export function promptForToken(prompt: string): Promise<string> {
     let token = "";
 
     const onData = (char: string) => {
-      const c = char.toString();
-
-      if (c === "\n" || c === "\r") {
-        cleanup();
-        process.stdout.write("\n");
-        resolve(token);
-      } else if (c === "\u0003") {
-        cleanup();
-        process.stdout.write("\n");
-        process.exit(1);
-      } else if (c === "\u007f" || c === "\b") {
-        if (token.length > 0) {
-          token = token.slice(0, -1);
-          process.stdout.write("\b \b");
+      const chunk = char.toString();
+
+      for (const c of chunk) {
+        if (c === "\n" || c === "\r") {
+          cleanup();
+          process.stdout.write("\n");
+          resolve(token);
+          return;
+        } else if (c === "\u0003") {
+          cleanup();
+          process.stdout.write("\n");
+          process.exit(1);
+          return;
+        } else if (c === "\u007f" || c === "\b") {
+          if (token.length > 0) {
+            token = token.slice(0, -1);
+            process.stdout.write("\b \b");
+          }
+        } else if (c >= " ") {
+          token += c;
+          process.stdout.write("*");
         }
-      } else if (c >= " ") {
-        token += c;
-        process.stdout.write("*");
       }
     };