Skip to content

fix(ci): skip changeset-check on the version-packages PR #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alerizzo merged 2 commits into from
Jun 26, 2026
Merged

fix(ci): skip changeset-check on the version-packages PR #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
452523f
fix(ci): skip changeset-check on the version-packages PR
alerizzo Jun 26, 2026
a64cbf6
chore(ci): match changeset-release/ prefix in changeset-check skip
alerizzo Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/skip-changeset-check-on-version-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
---

Internal CI change (no version bump): skip the `changeset-check` job on the
changesets bot's "version packages" PR (`changeset-release/main`). That PR
consumes (deletes) changesets rather than adding them, so the check counted 0
added/modified changeset files and always failed.
Comment on lines +4 to +7

@gemini-code-assist gemini-code-assist Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The actual CI workflow file changes (such as adding the github.head_ref != 'changeset-release/main' guard) are missing from this pull request. Currently, the only modified file is this changeset markdown file. Please commit and push the workflow changes to this branch to complete the implementation.

@alerizzo alerizzo Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a misread — the workflow change is included. The PR touches 2 files: .github/workflows/ci.yml (adds the changeset-check guard) and this changeset. You can see it in the diff, and the changeset-check job is already passing green on this PR. No action needed.

🤖 Generated by /pr-fixup command

4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ jobs:
run: npm test

changeset-check:
if: github.event_name == 'pull_request'
# Skip the changesets bot's "version packages" PR: it consumes (deletes)
# changesets rather than adding them, so it would always fail this check.
if: github.event_name == 'pull_request' && github.head_ref != 'changeset-release/main'

@codacy-production codacy-production Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: The branch name check is restricted to 'main'. If you use other base branches for releases, this check will fail. Using a prefix check handles all release branches.

Suggested change
if: github.event_name == 'pull_request' && github.head_ref != 'changeset-release/main'
if: github.event_name == 'pull_request' && !startsWith(github.head_ref, 'changeset-release/')

@alerizzo alerizzo Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call — adopted. Switched to !startsWith(github.head_ref, 'changeset-release/') so it covers the bot's branch for any base branch, not just main.

🤖 Generated by /pr-fixup command

runs-on: ubuntu-latest

steps:
Expand Down
Loading