Skip to content

fix vue parser#4971

Merged
DMarinhoCodacy merged 1 commit into
masterfrom
fix-vue-parser
May 7, 2026
Merged

fix vue parser#4971
DMarinhoCodacy merged 1 commit into
masterfrom
fix-vue-parser

Conversation

@DMarinhoCodacy

Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR correctly introduces basic Vue support by configuring the parser and extension resolution; however, the implementation is incomplete. Specifically, .vue files are missing from the global TypeScript rules override block and the import/parsers setting. This prevents TypeScript-specific linting rules from applying to Vue components and may cause resolution errors. Additionally, the PR lacks automated test scenarios to verify that the configuration works as intended for script blocks and module resolution.

About this PR

  • No automated tests or sample Vue files were included in the PR to validate that the configuration changes correctly handle Vue files.
  • The PR description is empty, providing no context on why these specific changes were necessary or what specific issue with the Vue parser is being fixed.

Test suggestions

  • Missing recommended test scenario: Verify that linting a .vue file with TypeScript script blocks does not produce parser errors.
  • Missing recommended test scenario: Verify that importing a .vue file from a .ts file is correctly resolved by the eslint-plugin-import.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Missing recommended test scenario: Verify that linting a .vue file with TypeScript script blocks does not produce parser errors.
2. Missing recommended test scenario: Verify that importing a .vue file from a .ts file is correctly resolved by the eslint-plugin-import.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread src/eslintDefaultOptions.ts
Comment thread src/eslintDefaultOptions.ts
Comment thread src/eslintDefaultOptions.ts
Comment thread src/eslintDefaultOptions.ts
Comment thread src/eslintDefaultOptions.ts
@DMarinhoCodacy
DMarinhoCodacy merged commit 0784086 into master May 7, 2026
5 checks passed
@DMarinhoCodacy
DMarinhoCodacy deleted the fix-vue-parser branch May 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants