fix vue parser#4971
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The PR correctly introduces basic Vue support by configuring the parser and extension resolution; however, the implementation is incomplete. Specifically, .vue files are missing from the global TypeScript rules override block and the import/parsers setting. This prevents TypeScript-specific linting rules from applying to Vue components and may cause resolution errors. Additionally, the PR lacks automated test scenarios to verify that the configuration works as intended for script blocks and module resolution.
About this PR
- No automated tests or sample Vue files were included in the PR to validate that the configuration changes correctly handle Vue files.
- The PR description is empty, providing no context on why these specific changes were necessary or what specific issue with the Vue parser is being fixed.
Test suggestions
- Missing recommended test scenario: Verify that linting a .vue file with TypeScript script blocks does not produce parser errors.
- Missing recommended test scenario: Verify that importing a .vue file from a .ts file is correctly resolved by the eslint-plugin-import.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Missing recommended test scenario: Verify that linting a .vue file with TypeScript script blocks does not produce parser errors.
2. Missing recommended test scenario: Verify that importing a .vue file from a .ts file is correctly resolved by the eslint-plugin-import.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
No description provided.