build(deps): bump pdepend/pdepend from 2.12.1 to 2.16.2#357
build(deps): bump pdepend/pdepend from 2.12.1 to 2.16.2#357dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [pdepend/pdepend](https://github.com/pdepend/pdepend) from 2.12.1 to 2.16.2. - [Release notes](https://github.com/pdepend/pdepend/releases) - [Changelog](https://github.com/pdepend/pdepend/blob/3.x/CHANGELOG.md) - [Commits](pdepend/pdepend@2.12.1...2.16.2) --- updated-dependencies: - dependency-name: pdepend/pdepend dependency-version: 2.16.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
While this PR intends to bump pdepend/pdepend to add PHP 8.3 support, it currently should not be merged. The update introduces a significant breaking change by raising the minimum PHP requirement to 8.4 via transitive dependencies (specifically symfony/var-exporter v8.0.9), which is not documented in the PR description. Furthermore, the composer.lock file contains invalid metadata, including package versions with release dates in the year 2026, indicating a corrupted or non-standard generation environment. To resolve this, a PHP constraint should be added to composer.json to prevent the resolver from selecting incompatible transitive dependencies before regenerating the lock file.
About this PR
- The PR description focuses on a minor version bump of pdepend but fails to address that the transitive dependency updates (upgrading Symfony components to v7 and v8) effectively mandate PHP 8.2 or 8.4. This is a breaking change for the project's supported environments.
Test suggestions
- Verify that PDepend 2.16.2 correctly parses PHP 8.3 codebases without errors.
- Verify that existing metric calculation logic remains consistent and correct with the new library version.
- Validate runtime compatibility with PHP 8.4, which is necessitated by the new transitive dependency
symfony/var-exporterv8.0.9.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that PDepend 2.16.2 correctly parses PHP 8.3 codebases without errors.
2. Verify that existing metric calculation logic remains consistent and correct with the new library version.
3. Validate runtime compatibility with PHP 8.4, which is necessitated by the new transitive dependency `symfony/var-exporter` v8.0.9.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "name": "symfony/polyfill-php81", | ||
| "version": "v1.27.0", | ||
| "name": "symfony/var-exporter", | ||
| "version": "v8.0.9", |
There was a problem hiding this comment.
🔴 HIGH RISK
The updated transitive dependency symfony/var-exporter (v8.0.9) requires PHP 8.4 or higher. Please ensure that all project environments (local, CI, and production) are compatible with this version before proceeding, or constrain the version in composer.json.
| { | ||
| "name": "symfony/config", | ||
| "version": "v5.4.11", | ||
| "version": "v7.4.10", |
There was a problem hiding this comment.
🔴 HIGH RISK
The version 'v7.4.10' for symfony/config and several other packages in this lock file are invalid as they refer to non-existent versions with future release dates (e.g., year 2026). Additionally, these versions require PHP 8.2 or higher. This suggests the composer.lock file was generated incorrectly and will cause installation failures.
| "description": "Metrics tool for PHP based on PDepend", | ||
| "require": { | ||
| "pdepend/pdepend": "2.12.1" | ||
| "pdepend/pdepend": "2.16.2" |
There was a problem hiding this comment.
🔴 HIGH RISK
Suggestion: This dependency update significantly raises the minimum PHP requirement to 8.4 due to the versions selected for transitive dependencies in the lock file. To ensure compatibility with older PHP versions, you should explicitly define a PHP constraint in your require block.
Try running the following prompt in your coding agent:
Add a PHP constraint to the 'require' section of composer.json (e.g., '"php": ">=8.1"') and regenerate the composer.lock file using 'composer update'.
Bumps pdepend/pdepend from 2.12.1 to 2.16.2.
Release notes
Sourced from pdepend/pdepend's releases.
... (truncated)
Changelog
Sourced from pdepend/pdepend's changelog.
... (truncated)
Commits
f942b20Merge pull request #706 from pdepend/release/2.16.2-released5bbaa6Add 2.16.2 changelog9dcc17fMerge pull request #705 from pdepend/feature/throw-in-value411cea3Add support for throw expressions in array index accessa5d739dShow issue with throw in key66ceb05Merge pull request #700 from pdepend/release/2.16.1-release42fbdddFix consistency with release not wordingfb6c54eAdd changelog for 2.16.171602dfMerge pull request #699 from pdepend/fix/symfony-compatibilitya14bfb7Build phar with Configuration weak typesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)