infra: parallelize deployment scale-ups

[CallMeLeopoldo]

No description provided.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes. Give us feedback}

[codacy-production]

Pull Request Overview

This PR introduces critical syntax errors that will cause the CI/CD job to fail upon execution. While the title suggests parallelizing deployment scale-ups, the implementation remains sequential and introduces logic that prematurely exits the job before all deployments can be processed.

Codacy reported the PR as 'up to standards', likely because the static analysis did not deeply parse the Bash script embedded within the YAML. However, manual review shows that the error-handling logic is broken due to literal string comparisons and missing control flow keywords. These issues must be addressed to prevent immediate deployment failures.

About this PR

• The implementation does not reflect the PR title. The scale-up process remains sequential; there is no use of background processes (&) or wait commands to achieve parallelization.

Test suggestions

• Verify that multiple failed deployments are correctly appended to the error_deployments array.
• Verify that the job fails with exit 1 when the error_deployments array is non-empty.
• Verify behavior when wait_for_pods_ready is false (should not trigger rollout status checks).

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify that multiple failed deployments are correctly appended to the error_deployments array.
2. Verify that the job fails with exit 1 when the error_deployments array is non-empty.
3. Verify behavior when wait_for_pods_ready is false (should not trigger rollout status checks).

---

🗒️ Improve review quality by adding custom instructions