Skip to content

feat: add overwrite-only mode for ECR mirroring TAROT-3721 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lolgab merged 1 commit into from
Jun 2, 2026
+16 −1
Merged

feat: add overwrite-only mode for ECR mirroring TAROT-3721 #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/jobs/mirror_to_ecr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ parameters:
description: If true then force mirroring the image even if it already exists in ECR
type: boolean
default: false
overwrite_only_existing:
description: If true then overwrite the image only when the target tag already exists in ECR. The job fails if the tag is missing.
type: boolean
default: false
aws_profile:
description: The AWS profile to be used
type: string
Expand Down Expand Up @@ -67,7 +71,18 @@ steps:

echo "Mirroring ${SRC} to ${ECR_URL}/${MIRROR}..."
REPO_DATA=$(aws ecr describe-images --repository-name=${MIRROR_NAME} --image-ids=imageTag=${MIRROR_TAG} ||: )
if << parameters.force>> || [[ -z $REPO_DATA ]] ; then
SHOULD_MIRROR=false
if [[ -z $REPO_DATA ]] ; then
Copy link
Copy Markdown

@codacy-production codacy-production Bot Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: It's recommended to quote the variable expansion to handle potential edge cases in the command output and maintain style consistency.\n\nThis might be a simple fix:\nsuggestion\n if [[ -z "$REPO_DATA" ]] ; then\n

if << parameters.overwrite_only_existing >> ; then
echo "Mirror target ${MIRROR} does not exist in ECR and overwrite_only_existing is enabled."
exit 1
fi
SHOULD_MIRROR=true
elif << parameters.force >> || << parameters.overwrite_only_existing >> ; then
SHOULD_MIRROR=true
fi

if [[ "${SHOULD_MIRROR}" == "true" ]] ; then
docker pull ${SRC}
docker tag ${SRC} ${ECR_URL}/${MIRROR}
docker push ${ECR_URL}/${MIRROR}
Expand Down