-
Notifications
You must be signed in to change notification settings - Fork 5
Security: pin GitHub Actions to SHA hashes #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |
| - name: Check GitHub Issue type | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' | ||
| id: github_issue_type | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 MEDIUM RISK This action is pinned to an old version (v2.0.0) that uses the deprecated Node 12 runtime. Upgrade to v7 to ensure compatibility with modern GitHub runners. Additionally, avoid using Try running the following prompt in your coding agent:
|
||
| with: | ||
| result-encoding: string | ||
| script: | | ||
|
|
@@ -33,7 +33,7 @@ jobs: | |
| - name: Check if GitHub Issue has JIRA_ISSUE_LABEL | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' | ||
| id: github_issue_has_jira_issue_label | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||
| env: | ||
| JIRA_ISSUE_LABEL: ${{ secrets.JIRA_ISSUE_LABEL }} | ||
| with: | ||
|
|
@@ -56,7 +56,7 @@ jobs: | |
| - name: Jira Login | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: login | ||
| uses: atlassian/gajira-login@v2.0.0 | ||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 | ||
| env: | ||
| GITHUB_ISSUE_TYPE: ${{ steps.github_issue_type.outputs.result }} | ||
| GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL: ${{ steps.github_issue_has_jira_issue_label.outputs.result }} | ||
|
|
@@ -67,7 +67,7 @@ jobs: | |
| - name: Extract Jira number | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: extract_jira_number | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||
| env: | ||
| GITHUB_ISSUE_TYPE: ${{ steps.github_issue_type.outputs.result }} | ||
| GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL: ${{ steps.github_issue_has_jira_issue_label.outputs.result }} | ||
|
|
@@ -82,7 +82,7 @@ jobs: | |
| - name: Jira Add comment on issue | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: add_comment_jira_issue | ||
| uses: atlassian/gajira-comment@v2.0.2 | ||
| uses: atlassian/gajira-comment@8ec356b5df49f1325653db7ee2da2b59a1d78203 # v2.0.2 | ||
| env: | ||
| GITHUB_ISSUE_TYPE: ${{ steps.github_issue_type.outputs.result }} | ||
| GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL: ${{ steps.github_issue_has_jira_issue_label.outputs.result }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
The combination of
pull_request_targetand checking out the PR head is a security risk. It allows potentially untrusted code to run with the permissions of the base repository (privilegedGITHUB_TOKEN). Since this is for auto-merging, consider using GitHub's native auto-merge feature which can be triggered via a standardpull_requestevent and doesn't require checking out the PR code manually.Try running the following prompt in your IDE agent:
See Issue in Codacy