Skip to content

fix: Add expected vulnerabilities to tests#264

Merged
afsmeira merged 3 commits into
masterfrom
am/fix-tests
Apr 7, 2026
Merged

fix: Add expected vulnerabilities to tests#264
afsmeira merged 3 commits into
masterfrom
am/fix-tests

Conversation

@afsmeira

@afsmeira afsmeira commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Add expected vulnerabilities to tests.

@afsmeira afsmeira requested a review from a team April 7, 2026 08:03
@afsmeira afsmeira requested a review from a team as a code owner April 7, 2026 08:03
@codacy-production

codacy-production Bot commented Apr 7, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes. Give us feedback

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CircleCI configuration orbs and adjusts test expectations for vulnerability patterns. While the code is technically up to standards according to Codacy, there are significant logical concerns regarding the test data added to the XML results.

The review identified that the CVE identifier (CVE-2026-25645) references a year in the future, and the associated fix version for the 'requests' library (2.33.0) has not been released. These inconsistencies should be addressed to ensure the integration tests are valid and do not rely on mock data that could cause false positives or misleading results.

About this PR

  • The PR title and description are extremely sparse. Providing context for why specific vulnerabilities are being added or updated helps reviewers verify the validity of the test changes.

Test suggestions


🗒️ Improve review quality by adding custom instructions

Comment thread docs/multiple-tests/pattern-vulnerability-medium/results.xml Outdated
Comment thread docs/multiple-tests/pattern-vulnerability-medium/results.xml
@afsmeira afsmeira merged commit 6c505c0 into master Apr 7, 2026
8 checks passed
@afsmeira afsmeira deleted the am/fix-tests branch April 7, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants