feat: Remove resetConfig, change update logic CF-2031

Update will be called on startup, but check for
hardcoded CLI version is moved to update and
it will prevent calling `cli update`, not the
entire function. This ensures `cli config reset`
will be called when project opens/starts.

Author: og-pixel

src/cli/CodacyCli.ts

@@ -39,8 +39,6 @@ export abstract class CodacyCli {
 
   public abstract configDiscover(filePath: string): Promise<void>
 
-  public abstract configReset(): Promise<void>
-
   public getCliCommand(): string {
     return this._cliCommand
   }

src/cli/MacCodacyCli.ts

@@ -23,13 +23,8 @@ export class MacCodacyCli extends CodacyCli {
 
     if (fs.existsSync(fullPath)) {
       this.setCliCommand(this._cliVersion ? `CODACY_CLI_V2_VERSION=${this._cliVersion} ${localPath}` : localPath)
-
       // CLI found, update it if necessary
-      if (!this._cliVersion) {
-        await this.update()
-      }
-
-      return
+      return await this.update()
     }
 
     // CLI not found, attempt to install it
@@ -133,7 +128,10 @@ export class MacCodacyCli extends CodacyCli {
         Logger.debug('CLI mode is remote and no identification parameters provided. Skipping update and config reset.')
         return
       }
-      await this.execAsync(updateCommand)
+      //Call Update if CLI version is not set
+      if (!this._cliVersion) {
+        await this.execAsync(updateCommand)
+      }
       await this.execAsync(resetCommand, resetParams)
 
       // Initialize codacy-cli after update
@@ -276,16 +274,4 @@ export class MacCodacyCli extends CodacyCli {
       }
     }
   }
-  
-  public async configReset(): Promise<void> {
-    const resetCommand = `${this.getCliCommand()} config reset`
-    const resetParams = this.getIdentificationParameters()
-
-    const hasIdentificationParams = await this.validateIdentificationParameters(resetParams)
-    if (!hasIdentificationParams) {
-      Logger.debug('CLI mode is remote and no identification parameters provided. Skipping update and config reset.')
-      return
-    }
-    await this.execAsync(resetCommand, resetParams)
-  }
 }

src/cli/WinCodacyCli.ts

@@ -35,8 +35,4 @@ export class WinCodacyCli extends CodacyCli {
   public configDiscover(_filePath: string): Promise<void> {
     throw new Error(NOT_SUPPORTED)
   }
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  public configReset(): Promise<void> {
-    throw new Error(NOT_SUPPORTED)
-  }
 }

src/cli/index.ts

@@ -83,9 +83,6 @@ export class Cli {
 
     // set Cli command if found
     await this.cliInstance.preflightCodacyCli(false)
-    
-    // check for an already installed CLI to update tools config
-    await this.cliInstance.configReset()
 
     return this.cliInstance
   }