Merge pull request #189 from codacy/force-type-provider

clean: Change provider type

Author: inesgomas

src/common/parseGitRemote.ts

@@ -1,11 +1,13 @@
-const validProviders: Record<string, 'gh' | 'gl' | 'bb'> = {
+import { Provider } from '../api/client'
+
+const validProviders: Record<string, Provider> = {
   github: 'gh',
   gitlab: 'gl',
   bitbucket: 'bb',
 }
 
 interface GitRemoteInfo {
-  provider: 'gh' | 'gl' | 'bb'
+  provider: Provider
   organization: string
   repository: string
   originalRepository?: string
@@ -15,7 +17,7 @@ interface GitRemoteInfo {
  * Normalize repository name based on provider
  * For GitLab, extracts the last part of group/subgroup/project path
  */
-const normalizeRepositoryName = (provider: 'gh' | 'gl' | 'bb', repository: string): string => {
+const normalizeRepositoryName = (provider: Provider, repository: string): string => {
   if (provider === 'gl') {
     // For GitLab, take the last part of the path
     const parts = repository.split('/')

src/onboarding.ts

@@ -1,11 +1,11 @@
 import { Api } from './api'
 import * as vscode from 'vscode'
-import { OrganizationService } from './api/client'
+import { OrganizationService, Provider } from './api/client'
 import { CodacyCloud, CodacyCloudState } from './git/CodacyCloud'
 
 const ORGANIZATIONS_ITERATION_LIMIT = 5
 
-const findOrganization = async (provider: 'bb' | 'gh' | 'gl', organization: string, cursor?: string) => {
+const findOrganization = async (provider: Provider, organization: string, cursor?: string) => {
   try {
     let currentCursor = cursor
     let hasMore = true
@@ -45,7 +45,7 @@ const pendingJoinOrganizationStatus = async () => {
   return CodacyCloudState.HasPendingJoinOrganization
 }
 
-export const getRepositoryCodacyCloudStatus = async (provider: 'bb' | 'gh' | 'gl', organization: string) => {
+export const getRepositoryCodacyCloudStatus = async (provider: Provider, organization: string) => {
   const findOrgResult = await findOrganization(provider, organization)
   if (!findOrgResult.success) {
     // Organization not found on Codacy; User needs to add the organization
@@ -191,11 +191,7 @@ export const addRepository = async (codacyCloud: CodacyCloud) => {
   }
 }
 
-export const checkFirstAnalysisStatus = async (
-  provider: 'bb' | 'gh' | 'gl',
-  organization: string,
-  repository: string
-) => {
+export const checkFirstAnalysisStatus = async (provider: Provider, organization: string, repository: string) => {
   try {
     const { data } = await Api.Analysis.getFirstAnalysisOverview(provider, organization, repository)
     return data

src/views/ProblemsDiagnosticCollection.ts

@@ -5,7 +5,7 @@ import { CodacyCloud } from '../git/CodacyCloud'
 import { PullRequestIssue } from '../git/PullRequest'
 import { GitProvider } from '../git/GitProvider'
 import { BranchIssue } from '../git/IssuesManager'
-import { CommitIssue, SeverityLevel } from '../api/client'
+import { CommitIssue, Provider, SeverityLevel } from '../api/client'
 import { ProcessedSarifResult } from '../cli'
 import * as path from 'path'
 import Logger from '../common/logger'
@@ -371,7 +371,7 @@ export class ProblemsDiagnosticCollection implements vscode.Disposable {
  */
 export class IssueActionProvider implements vscode.CodeActionProvider {
   constructor(
-    private getParams?: () => { provider: string; organization: string; repository: string } | undefined,
+    private getParams?: () => { provider: Provider; organization: string; repository: string } | undefined,
     private cli?: CodacyCli
   ) {}
 

src/views/hasPermissions.ts

@@ -1,8 +1,8 @@
-import { Permission } from '../api/client'
+import { Permission, Provider } from '../api/client'
 import { Api } from '../api'
 
 export const hasPermission = async (
-  provider: string,
+  provider: Provider,
   organization: string,
   allowedByDefault: Permission,
   repositoryPermission?: Permission