Merge pull request #2098 from codalab/playwrightFixes

Playwright fixes

Author: acletournel

.circleci/config.yml

@@ -77,7 +77,7 @@ jobs:
       - run:
           name: "Tests: Run end-to-end (E2E) tests"
           command: |
-            cd tests && CI="true" $HOME/.local/bin/uv run pytest test_auth.py test_account_creation.py test_competition.py test_submission.py
+            cd tests && CI=True $HOME/.local/bin/uv run pytest test_auth.py test_account_creation.py test_competition.py test_submission.py
           no_output_timeout: 30m
 
       # Example to run specific set of tests (for debugging individual tests from a batch of tests)

.env_circleci

@@ -14,8 +14,6 @@ WORKER_CONNECTION_TIMEOUT=100000000 # milliseconds
 
 FLOWER_BASIC_AUTH=root:password-you-should-change
 
-SELENIUM_HOSTNAME=selenium
-
 DJANGO_SETTINGS_MODULE=settings.test
 
 # Minio local storage example

src/settings/test.py

@@ -20,7 +20,4 @@
 DEBUG_TOOLBAR_CONFIG = {
     "SHOW_TOOLBAR_CALLBACK": lambda request: False
 }
-
-SELENIUM_HOSTNAME = os.environ.get("SELENIUM_HOSTNAME", "localhost")
-
 IS_TESTING = True

tests/test_submission.py

@@ -101,7 +101,7 @@ def test_v18(page: Page):
 
 
 # Skip this test if in the CI
-@pytest.mark.skipif(ci, reason="Works locally but fails in the CI for some reason")
+@pytest.mark.skipif(ci, reason="Works locally but fails in the CI because of CELERY_TASK_ALWAYS_EAGER = True")
 def test_v2_multiTask(page: Page) -> None:
     page.goto("/")
     page.get_by_role("link", name=" Benchmarks/Competitions").click()
@@ -139,7 +139,7 @@ def test_v2_multiTask(page: Page) -> None:
     ).to_be_visible()
     # The ID on the leaderboard can be one of the children instead of the parent so we try them all
     found = False
-    for count in range(0, 4):
+    for count in range(0, 5):
         try:
             submission_ID_str = int(submission_Id[0]) + count
             logger.info("Looked for ID : " + str(submission_ID_str))
@@ -155,7 +155,7 @@ def test_v2_multiTask(page: Page) -> None:
 
 
 # Skip this test if in the CI
-@pytest.mark.skipif(ci, reason="Works locally but fails in the CI for some reason")
+@pytest.mark.skipif(ci, reason="Works locally but fails in the CI because of CELERY_TASK_ALWAYS_EAGER = True")
 def test_v2_multiTaskFactSheet(page: Page) -> None:
     page.goto("/")
     page.get_by_role("link", name=" Benchmarks/Competitions").click()
@@ -199,7 +199,7 @@ def test_v2_multiTaskFactSheet(page: Page) -> None:
     ).to_be_visible()
     # The ID on the leaderboard can be one of the children instead of the parent so we try them all
     found = False
-    for count in range(0, 4):
+    for count in range(0, 5):
         try:
             submission_ID_str = int(submission_Id[0]) + count
             logger.debug("Looked for ID : " + str(submission_ID_str))