Merge pull request #2276 from codalab/improve-submission-upload

ObadaS · web-flow · commit c17594233d0f · 2026-03-24T15:53:54.000+01:00
Clean minor code logic problems in submission_upload.tag
diff --git a/src/static/riot/competitions/detail/submission_upload.tag b/src/static/riot/competitions/detail/submission_upload.tag
@@ -269,7 +269,7 @@
                                 self.handle_websocket(event_data.submission_id, data)
                             }
                         })
-                        self.detailed_result_urls[submission_id] = detailed_result_url
+                        self.detailed_result_urls[event_data.submission_id] = detailed_result_url
                         self.update()
                         break
                     case 'message':
@@ -443,7 +443,7 @@
                     }
                 }
             }
-            return form_json === {} ? null : form_json
+            return _.isEmpty(form_json) ? null : form_json
         }
 
         self.upload = function () {
@@ -472,7 +472,7 @@
                     self.lines = {}
                     let dropdown = $('#organization_dropdown')
                     let organization = dropdown.dropdown('get value')
-                    if(organization === 'add_organization' | organization === 'None'){
+                    if(organization === 'add_organization' || organization === 'None'){
                         organization = null
                     }
                     dropdown.attr('disabled', 'disabled')

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@`
`269`	`269`	`self.handle_websocket(event_data.submission_id, data)`
`270`	`270`	`}`
`271`	`271`	`})`
`272`		`- self.detailed_result_urls[submission_id] = detailed_result_url`
	`272`	`+ self.detailed_result_urls[event_data.submission_id] = detailed_result_url`
`273`	`273`	`self.update()`
`274`	`274`	`break`
`275`	`275`	`case 'message':`
`@@ -443,7 +443,7 @@`
`443`	`443`	`}`
`444`	`444`	`}`
`445`	`445`	`}`
`446`		`- return form_json === {} ? null : form_json`
	`446`	`+ return _.isEmpty(form_json) ? null : form_json`
`447`	`447`	`}`
`448`	`448`
`449`	`449`	`self.upload = function () {`
`@@ -472,7 +472,7 @@`
`472`	`472`	`self.lines = {}`
`473`	`473`	`let dropdown = $('#organization_dropdown')`
`474`	`474`	`let organization = dropdown.dropdown('get value')`
`475`		`- if(organization === 'add_organization' \| organization === 'None'){`
	`475`	`+ if(organization === 'add_organization' \|\| organization === 'None'){`
`476`	`476`	`organization = null`
`477`	`477`	`}`
`478`	`478`	`dropdown.attr('disabled', 'disabled')`