Skip to content

Enable different HOST_DIRECTORY#2142

Closed
jbehley wants to merge 12 commits intocodalab:developfrom
jbehley:develop
Closed

Enable different HOST_DIRECTORY#2142
jbehley wants to merge 12 commits intocodalab:developfrom
jbehley:develop

Conversation

@jbehley
Copy link
Copy Markdown

@jbehley jbehley commented Feb 3, 2026

Brief Description

As we need a different host_directory not located in /codabench, but a different path due to mounting points, e.g., /other/path/codabench, we run into the problem that the worker raised a permission exception. As the directories are created inside the container of the worker, we identified the problem as not using the right location.

Thus, this PR should make it possible to have a different directory on the host.

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

… needs to be called before building the host directory.
@Didayolo Didayolo self-assigned this Feb 4, 2026
@Didayolo
Copy link
Copy Markdown
Member

Didayolo commented Feb 4, 2026

Hi @jbehley,

Thank you very much for your contribution.

I have the following doubt regarding your change.

Having first the directory creation:

        # Create if necessary
        os.makedirs(path, exist_ok=True)

And then the path concatenation:

        path = os.path.join(HOST_DIRECTORY, path)
        return path

It means that the path returned by the function is not the path passed to makedirs. It looks like we have then no guarantee that the directory exists. I may need to check it out more in depth I feel like this could introduce a bug.

@Didayolo Didayolo removed their assignment Feb 4, 2026
@ihsaan-ullah
Copy link
Copy Markdown
Collaborator

I think this PR needs to be reabsed after #2294 and #2303 are merged into develop

@jbehley
Copy link
Copy Markdown
Author

jbehley commented Mar 31, 2026

I think I have to close it anyway; I wasn't particularly careful with adding unrelated changes into the branch.

Still the problem is not resolved...in our current setup, I still need to run my customized version, which I synced to the latest version.

I'm still confident that the order should be different; otherwise, one tries to create a directory inside the container that cannot be accessed.

@jbehley jbehley closed this Mar 31, 2026
@ihsaan-ullah
Copy link
Copy Markdown
Collaborator

@jbehley Feel free to open a new PR when it is ready. In any case, there is no harm in adding details about the tweaks that work for you to this PR or another one, just to keep something for other users who may need this in the future

@jbehley
Copy link
Copy Markdown
Author

jbehley commented Apr 2, 2026

I opened a new pull request with just the required change: #2311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants