Conversation
|
@AndrewJGaut I don't think I can directly add you as a reviewer, so tagging you here. |
|
@HidyHan Thanks for tagging me. I went ahead and kicked off CI, but it looks like the formatting test failed. Looking closer at it, it appears the MyPy typing check failed. So perhaps the ignore comments are still needed... Either way, you can verify by running pre-commit again locally. (It may have failed when you ran it locally, but it's a bit hard to tell what failure looks like until you've run it a few times. Otherwise, maybe it's passing locally but failing when run on GHA, which would be surprising, but I've certainly seen weirder!) |
|
Taking a closer look.
@epicfaace any thoughts for quick fixes? If there are other benefits we can consider upgrading mypy version, but not sure whether this PR warrants it. |
|
Hmm @HidyHan the point of this issue was actually to upgrade mypy (#4536). See my message here (python/typeshed#5210). Basically I had contributed a missing type to mypy, and wanted to wait for a new mypy version so we can upgrade to it (so it can incorporate the new type). |
Related issues
Fixes #4533.
Checklist