Skip to content

4360 cl search bug fix #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AriWebb wants to merge 9 commits into
base: master
Choose a base branch
from
Open

4360 cl search bug fix #4545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6b29de
ready for testing
AriWebb Aug 18, 2023
2953a2d
remove print
AriWebb Aug 30, 2023
c94ca86
use parser.parse instead of datetime strptime
AriWebb Sep 29, 2023
ae1825e
add test for change
AriWebb Sep 29, 2023
f9a6398
lint changes
AriWebb Oct 3, 2023
7faf458
remove test that wasn't working as expected
AriWebb Oct 4, 2023
6a822e0
Merge branch 'master' into 4360-cl-search-bug-fix
AriWebb Nov 15, 2023
4d30e45
add unit test
AriWebb Nov 15, 2023
912e729
change test to check_not_equals
AriWebb Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codalab/model/bundle_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ def add_join(table: Table, condition: Any, left_outer_join: bool = False):
conjunct = condition
elif key in ('.before', '.after'):
try:
target_datetime = parser.isoparse(value)
target_datetime = parser.parse(value)
except ValueError:
raise UsageError(
"Unable to parse datetime. Datetime must be specified as an ISO-8601 datetime string such as YYYY-MM-DD."
Expand Down
6 changes: 6 additions & 0 deletions tests/cli/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,6 +1939,12 @@ def test_search_time(ctx):
time.sleep(1)
time3 = datetime.now().isoformat()

# Check date format works correctly, GH issue #4360
check_not_equals(
Copy link
Copy Markdown
Collaborator

@percyliang percyliang Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is oddly specific - can we test for what the output should be?

'UsageError: Unable to parse datetime. Datetime must be specified as an ISO-8601 datetime string such as YYYY-MM-DD.',
_run_command([cl, 'search', '.before=2023-1-11', '.count']),
)

# No results
check_equals('', _run_command([cl, 'search', 'name=' + name, '.before=' + time1, '-u']))
check_equals('', _run_command([cl, 'search', 'name=' + name, '.after=' + time3, '-u']))
Expand Down