Improve PHPStan situation

Author: d-s-codappix

Classes/TestingFramework.php

@@ -68,7 +68,7 @@ protected function assertPHPDataSet(string $filePath): void
                 // Unset already asserted record to only keep unexpected records.
                 unset($records[$result]);
 
-                // Increase assertion counter
+                // @phpstan-ignore staticMethod.alreadyNarrowedType (We want to increase assertion counter, but there is no public API)
                 self::assertTrue(true);
             }
 
@@ -100,6 +100,7 @@ private function getDataSet(string $filePath): array
             throw new \RuntimeException('Given file did not return an array: ' . $filePath, 1760942255);
         }
 
+        // @phpstan-ignore return.type (We don't want to validate the whole structure)
         return $dataSet;
     }
 
@@ -111,12 +112,11 @@ private function ensureFileExists(string $filePath): void
     }
 
     /**
-     * @param array{uid: int|string|null} $assertion
-     * @param array<string|int, mixed[]> $records
+     * @param array<string, string> $assertion
+     * @param mixed[] $records
      */
     private function getAssertionErrorMessageForNoneMatchingRecord(array $assertion, array $records, string $tableName): string
     {
-        // Handle error
         if (isset($assertion['uid']) && empty($records[$assertion['uid']])) {
             return 'Record "' . $tableName . ':' . $assertion['uid'] . '" not found in database';
         }

phpstan-baseline.neon

@@ -18,32 +18,8 @@ parameters:
 			count: 1
 			path: Classes/Converter/Xml.php
 
-		-
-			rawMessage: 'Call to static method PHPUnit\Framework\Assert::assertTrue() with true will always evaluate to true.'
-			identifier: staticMethod.alreadyNarrowedType
-			count: 1
-			path: Tests/Functional/AbstractFunctionalTestCase.php
-
 		-
 			rawMessage: 'Cognitive complexity for "Codappix\Typo3PhpDatasets\Tests\Functional\AbstractFunctionalTestCase::assertPHPDataSet()" is 12, keep it under 9'
 			identifier: complexity.functionLike
 			count: 1
 			path: Tests/Functional/AbstractFunctionalTestCase.php
-
-		-
-			rawMessage: 'Method Codappix\Typo3PhpDatasets\Tests\Functional\AbstractFunctionalTestCase::getDataSet() should return array<string, array<array<string, string>>> but returns array<mixed, mixed>.'
-			identifier: return.type
-			count: 1
-			path: Tests/Functional/AbstractFunctionalTestCase.php
-
-		-
-			rawMessage: 'Parameter #1 $assertion of method Codappix\Typo3PhpDatasets\Tests\Functional\AbstractFunctionalTestCase::getAssertionErrorMessageForNoneMatchingRecord() expects array{uid: int|string|null}, array<string, string> given.'
-			identifier: argument.type
-			count: 1
-			path: Tests/Functional/AbstractFunctionalTestCase.php
-
-		-
-			rawMessage: 'Parameter #2 $records of method Codappix\Typo3PhpDatasets\Tests\Functional\AbstractFunctionalTestCase::getAssertionErrorMessageForNoneMatchingRecord() expects array<int|string, array<mixed>>, array given.'
-			identifier: argument.type
-			count: 1
-			path: Tests/Functional/AbstractFunctionalTestCase.php