Skip to content

💡playerPlaybackSpeedButton defined twice in player.js #3823

Open
#3824
Open
💡playerPlaybackSpeedButton defined twice in player.js#3823
#3824
Labels
Feature requestWish or ideagood first issueA GitHub standard for inviting (new) contributors *Congratulations in advance!*help wantedJust an old github standard we add automatically. (The team can remove it when working on it.)up-for-grabs(a github standard for inviting new contributors) - Welcome! ♥
@hkzo

Description

@hkzo
hkzo
opened on May 1, 2026

⚬ PROBLEM: ImprovedTube.playerPlaybackSpeedButton is defined twice in player.js. The second definition (after playerRotateButton) silently overwrites the first, leaving it as dead code.

SHORT Table (Summary)
Problem playerPlaybackSpeedButton defined twice in player.js; first definition is dead code, silently overwritten
Solution Remove the first (dead) definition or merge both into one coherent implementation in player.js
Alternatives Keep only the second definition as-is (status quo behavior)
Scope All users with Playback Speed Button enabled; contributor/maintainer clarity
Side effects No runtime regression expected; cleanup only
Context Two definitions in player.js — search playerPlaybackSpeedButton = function to reproduce

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature requestWish or ideagood first issueA GitHub standard for inviting (new) contributors *Congratulations in advance!*help wantedJust an old github standard we add automatically. (The team can remove it when working on it.)up-for-grabs(a github standard for inviting new contributors) - Welcome! ♥

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions