Skip to content

Keep comments sidebar applied after refresh#3881

Open
puneetdixit200 wants to merge 1 commit into
code-charity:masterfrom
puneetdixit200:fix-comments-sidebar-refresh
Open

Keep comments sidebar applied after refresh#3881
puneetdixit200 wants to merge 1 commit into
code-charity:masterfrom
puneetdixit200:fix-comments-sidebar-refresh

Conversation

@puneetdixit200
Copy link
Copy Markdown

Fixes #3880

Summary

  • reapply the comments sidebar layout when YouTube rebuilds the watch page DOM
  • guard the sidebar setup while comments/related/sidebar nodes are still loading
  • avoid stacking duplicate scrollbar styles and resize observers
  • add a regression test for refresh/default-layout restoration and late-loading comments

Tests

  • npm_config_cache=$PWD/.npm-cache npx jest tests/unit/comments-sidebar.test.js --runInBand
  • npm_config_cache=$PWD/.npm-cache npm test -- --runInBand
  • npm_config_cache=$PWD/.npm-cache npx jest --runInBand
  • npm_config_cache=$PWD/.npm-cache npm run lint
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞[Bug] "Comments in Sidebar" feature reverts to default bottom layout on page refresh (F5)

1 participant