Merge pull request #59 from josemarluedke/lazy-config

Lazy publishableKey config

Author: lindyhopchris

README.md

@@ -56,6 +56,7 @@ $ ember install ember-stripe-elements
 
 You must set your [publishable key](https://support.stripe.com/questions/where-do-i-find-my-api-keys) in `config/environment.js`.
 
+
 ```js
 ENV.stripe = {
   publishableKey: 'pk_thisIsATestKey'
@@ -107,6 +108,12 @@ export default Route.extend({
 });
 ```
 
+You can also pass `publishableKey` to the `load` function.
+
+```js
+this.get('stripe').load('pk_thisIsATestKey');
+```
+
 ## Components
 
 ### Basics

addon/services/stripev3.js

@@ -4,6 +4,7 @@ import { getProperties, setProperties } from '@ember/object';
 import { readOnly } from '@ember/object/computed';
 import { resolve } from 'rsvp';
 import loadScript from 'ember-stripe-elements/utils/load-script';
+import EmberError from '@ember/error';
 
 // As listed at https://stripe.com/docs/stripe-js/reference#the-stripe-object
 const STRIPE_FUNCTIONS = [
@@ -30,10 +31,11 @@ export default Service.extend({
 
   lazyLoad: readOnly('config.lazyLoad'),
   mock: readOnly('config.mock'),
-  publishableKey: readOnly('config.publishableKey'),
+  publishableKey: null,
 
   init() {
     this._super(...arguments);
+    this.set('publishableKey', this.get('config.publishableKey'))
 
     let lazyLoad = this.get('lazyLoad');
 
@@ -42,7 +44,11 @@ export default Service.extend({
     }
   },
 
-  load() {
+  load(publishableKey = null) {
+    if (publishableKey) {
+      this.set('publishableKey', publishableKey);
+    }
+
     let lazyLoad = this.get('lazyLoad');
     let mock = this.get('mock');
     let shouldLoad = lazyLoad && !mock
@@ -61,6 +67,9 @@ export default Service.extend({
     if (!didConfigure) {
       let publishableKey = this.get('publishableKey');
 
+      if (!publishableKey) {
+        throw new EmberError("stripev3: Missing Stripe key, please set `ENV.stripe.publishableKey` in config.environment.js");
+      }
 
       let stripe = new Stripe(publishableKey);
       let functions = getProperties(stripe, STRIPE_FUNCTIONS);

app/initializers/ember-stripe-elements.js

@@ -1,4 +1,3 @@
-import EmberError from '@ember/error';
 import config from '../config/environment';
 import StripeMock from 'ember-stripe-elements/utils/stripe-mock';
 
@@ -9,10 +8,6 @@ export function initialize() {
   application.register('config:stripe', stripeConfig, { instantiate: false });
   application.inject('service:stripev3', 'config', 'config:stripe');
 
-  if (!stripeConfig.publishableKey) {
-    throw new EmberError("stripev3: Missing Stripe key, please set `ENV.stripe.publishableKey` in config.environment.js");
-  }
-
   if (typeof FastBoot !== 'undefined' || stripeConfig.mock) {
     window.Stripe = StripeMock;
   }

tests/acceptance/publishable-key-test.js

@@ -212,4 +212,28 @@ module('Unit | Service | stripev3', function(hooks) {
     confirmSetupIntent(mockOptions);
     confirmSetupIntent.restore();
   });
+
+  test('it throws an error if config.stripe.publishableKey is not set', function(assert) {
+    assert.expectAssertion(() => {
+      this.owner.factoryFor('service:stripev3').create({
+        config: {
+          mock: true,
+          publishableKey: null
+        }
+      });
+    }, /Missing Stripe key/);
+  });
+
+  test('it does not throw when publishableKey is provided by load method', async function(assert) {
+    this.subject = this.owner.factoryFor('service:stripev3').create({
+      config: {
+        mock: true,
+        lazyLoad: true,
+        publishableKey: null
+      }
+    });
+
+    await this.subject.load('some-key');
+    assert.ok(this.subject.get('didConfigure'), 'should have configured')
+  });
 });