Skip to content

Updates to portal#1

Open
JakeNeyer wants to merge 2 commits into
code-for-charlottesville:mainfrom
JakeNeyer:main
Open

Updates to portal#1
JakeNeyer wants to merge 2 commits into
code-for-charlottesville:mainfrom
JakeNeyer:main

Conversation

@JakeNeyer

Copy link
Copy Markdown
* Export both active and inactive customers
* Add additional fields to volunteer export (email, first name, last name, last job, end reason, and end date)
* Add ability to make volunteers active/inactive
* Remove empty pages from generated route report
* Add meal and client count to job overview page
* Sort customers in reports alphabetically
* Add database seed script to load db with fake data for local development

    * Export both active and inactive customers
    * Add additional fields to volunteer export (email, first name, last name, last job, end reason, and end date)
    * Add ability to make volunteers active/inactive
    * Remove empty pages from generated route report
    * Add meal and client count to job overview page
    * Sort customers in reports alphabetically
@JakeNeyer

Copy link
Copy Markdown
Author

@awhicks tagging you for review

@awhicks awhicks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a couple small comments that you don't need to address, just information!

Comment thread src/pdfs/views.py Outdated
date__lte=end_date) .values("date") .annotate(
total_meals=Sum("num_meals")) .order_by("date"))

print(date_meals_query)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need this!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that 🙃

@@ -0,0 +1,120 @@
from django.core.management.base import BaseCommand

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with this, but I think we do have some sample data, it just doesn't have a nice wrapper around if you were looking for something else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants