Voucher dropdown + Miscellaneous fixes#133
Conversation
|
Seems like it broke some tests, not exactly sure what though |
billyhunt
left a comment
billyhunt
left a comment
There was a problem hiding this comment.
Nice work! Maybe fix some of the stuff I mentioned if you feel like it.
| 1 | ||
| } | ||
| onSetPage={(index) => props.pagination.page = index} | ||
| onSetPage={(index) => (props.pagination.page = index)} |
There was a problem hiding this comment.
Not sure what is going on here. You are setting the prop to index? Should you be setting state?
There was a problem hiding this comment.
I'm not exactly sure- maybe it's intended as a Redux update? Was someone working on fixing the pagination? Otherwise I can look into this
| <Col xs="10" style={{ paddingLeft: "15px" }}> | ||
| Pets allowed | ||
| </Col> | ||
| <Col xs="10">Pets allowed</Col> |
There was a problem hiding this comment.
Did it not need the padding anymore?
There was a problem hiding this comment.
I moved the padding "up a level"- the class name px-3 adds the padding to the parent instead of each child having their own padding
| > | ||
| <path | ||
| fill-rule="evenodd" | ||
| fillRule="evenodd" |
There was a problem hiding this comment.
Not sure, I think it has to do with SVG formats; just changed it because it was throwing a warning (because React prefers camel-cased params)
|
Looks like you have to update your snapshots |
Oh ok! How would I do that? |
|
Sorry I missed this. Did you get it figured out? Slack me tomorrow if not. |
2 participants
I have the frontend for the voucher done (still need to do redux/api) and also added a variety of tweaks/fixes:
NestedDOM <a>warningNestedDOM <td> <button>warningfill-rulewarningscrollableto make modal scroll correctlySearchTool.js