Skip to content

Commit a768f70

Browse files
committed
small update
1 parent 855e600 commit a768f70

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

src/remix/metadata.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ describe("generateMeta suite", () => {
1111
const baseExpected = [
1212
{ title: "Test Page" },
1313
{ property: "og:title", content: "Test Page" },
14-
{ property: "og:description", content: "This is a test page." },
14+
{ property: "og:description", name: "description", content: "This is a test page." },
1515
{ property: "og:url", content: "https://example.com" },
16-
{ name: "twitter:card", content: "summary_large_image" },
16+
{ name: "twitter:card", property: "twitter:card", content: "summary_large_image" },
1717
]
1818

1919
it("generates meta tags with required fields", () => {
@@ -36,7 +36,7 @@ describe("generateMeta suite", () => {
3636
it("uses custom twitterCard if provided", () => {
3737
const metaData = { ...baseMetaData, twitterCard: "summary" }
3838
const expected = baseExpected.map((tag) =>
39-
tag.name === "twitter:card" ? { name: "twitter:card", content: "summary" } : tag
39+
tag.name === "twitter:card" ? { name: "twitter:card", property: "twitter:card", content: "summary" } : tag
4040
)
4141
expect(generateMeta(metaData)).toEqual(expected)
4242
})

src/remix/metadata.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ export const generateMeta = (metaData: MetaData, additionalData?: MetaDescriptor
8787
return [
8888
{ title },
8989
{ property: "og:title", content: title },
90-
{ property: "og:description", content: description },
90+
{ property: "og:description", name: "description", content: description },
9191
{ property: "og:url", content: url },
92-
{ name: "twitter:card", content: twitterCard },
92+
{ name: "twitter:card", property: "twitter:card", content: twitterCard },
9393
...(siteName ? [{ name: "og:site_name", content: siteName }] : []),
9494
...(image ? [{ property: "og:image", content: image }] : []),
9595
...(additionalData ?? []),

test-apps/remix-vite/app/routes/_index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export const meta: MetaFunction = () => {
1010
description: "test",
1111
url: "test",
1212
image: "https://picsum.photos/200/300",
13-
twitterCard: "summary_large_image",
1413
}, [
1514
{
1615
"script:ld+json": article({

0 commit comments

Comments
 (0)