Skip to content

Commit 5a470ea

Browse files
committed
refactor: compare eslint
1 parent 17cadd0 commit 5a470ea

5 files changed

Lines changed: 301 additions & 200 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 99 deletions
Original file line numberDiff line numberDiff line change
@@ -11,26 +11,6 @@ env:
1111
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
1212

1313
jobs:
14-
format:
15-
runs-on: ubuntu-latest
16-
name: Format check
17-
steps:
18-
- name: Checkout repository
19-
uses: actions/checkout@v4
20-
with:
21-
fetch-depth: 0
22-
- name: Set up Node.js
23-
uses: actions/setup-node@v4
24-
with:
25-
node-version-file: .nvmrc
26-
cache: npm
27-
- name: Set base and head for Nx affected commands
28-
uses: nrwl/nx-set-shas@v4
29-
- name: Install dependencies
30-
run: npm ci
31-
- name: Check formatting of affected files
32-
run: npx nx format:check
33-
3414
lint:
3515
runs-on: ubuntu-latest
3616
name: Linter
@@ -49,83 +29,11 @@ jobs:
4929
- name: Install dependencies
5030
run: npm ci
5131
- name: Lint affected projects
52-
run: npx nx affected:lint --parallel=3
53-
54-
unit-test:
55-
strategy:
56-
fail-fast: false
57-
matrix:
58-
os: [ubuntu-latest, windows-latest, macos-latest]
59-
name: Unit tests
60-
runs-on: ${{ matrix.os }}
61-
steps:
62-
- name: Checkout repository
63-
uses: actions/checkout@v4
64-
with:
65-
fetch-depth: 0
66-
- name: Set up Node.js
67-
uses: actions/setup-node@v4
68-
with:
69-
node-version-file: .nvmrc
70-
cache: npm
71-
- name: Set base and head for Nx affected commands
72-
uses: nrwl/nx-set-shas@v4
73-
- name: Install dependencies
74-
run: npm ci
75-
- name: Unit test affected projects
76-
run: npx nx affected -t unit-test --parallel=3 --coverage.enabled
32+
run: npx nx run-many -t lint --concurrency 5 --skipNxCache --parallel=1
7733

78-
integration-test:
79-
strategy:
80-
fail-fast: false
81-
matrix:
82-
os: [ubuntu-latest, windows-latest, macos-latest]
83-
name: Integration tests
84-
runs-on: ${{ matrix.os }}
85-
steps:
86-
- name: Checkout repository
87-
uses: actions/checkout@v4
88-
with:
89-
fetch-depth: 0
90-
- name: Set up Node.js
91-
uses: actions/setup-node@v4
92-
with:
93-
node-version-file: .nvmrc
94-
cache: npm
95-
- name: Set base and head for Nx affected commands
96-
uses: nrwl/nx-set-shas@v4
97-
- name: Install dependencies
98-
run: npm ci
99-
- name: Integration test affected projects
100-
run: npx nx affected -t int-test --parallel=3 --coverage.enabled
101-
102-
e2e:
103-
strategy:
104-
fail-fast: false
105-
matrix:
106-
os: [ubuntu-latest, windows-latest, macos-latest]
107-
name: E2E tests
108-
runs-on: ${{ matrix.os }}
109-
steps:
110-
- name: Checkout repository
111-
uses: actions/checkout@v4
112-
with:
113-
fetch-depth: 0
114-
- name: Set up Node.js
115-
uses: actions/setup-node@v4
116-
with:
117-
node-version-file: .nvmrc
118-
cache: npm
119-
- name: Set base and head for Nx affected commands
120-
uses: nrwl/nx-set-shas@v4
121-
- name: Install dependencies
122-
run: npm ci
123-
- name: E2E test affected projects
124-
run: npx nx affected -t e2e-test --parallel=1
125-
126-
build:
34+
lint-multi:
12735
runs-on: ubuntu-latest
128-
name: Build
36+
name: Linter with multithreading feature set to 4
12937
steps:
13038
- name: Checkout repository
13139
uses: actions/checkout@v4
@@ -140,7 +48,5 @@ jobs:
14048
uses: nrwl/nx-set-shas@v4
14149
- name: Install dependencies
14250
run: npm ci
143-
- name: Build all projects # affected is not used to be able to test-releae packages
144-
run: npx nx run-many --target=build --parallel=3
145-
- name: Test-release packages
146-
run: npx pkg-pr-new publish "packages/**/dist"
51+
- name: Lint affected projects
52+
run: npx nx run-many -t lint-multi --concurrency 5 --skipNxCache --parallel=1

nx.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,14 @@
166166
"filterByTags": ["publishable"]
167167
}
168168
}
169+
},
170+
{
171+
"plugin": "./tools/src/eslint-concurrency-target/eslint-concurrency-target.plugin.js",
172+
"options": {
173+
"targetName": "lint-multi",
174+
"maxWarnings": 0,
175+
"cache": true
176+
}
169177
}
170178
],
171179
"nxCloudId": "65d4d862d2adb16a45a4bc7c"

0 commit comments

Comments
 (0)